use shared response mock #12879

merged 3 commits into from Jan 18, 2017


None yet

4 participants

ragnerok commented Jan 8, 2017

Signed-off-by: osaid

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@ragnerok ragnerok use shared response mock
Signed-off-by: osaid <>

This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: test/classes/plugin/auth/AuthenticationSignonTest.php

ragnerok added some commits Jan 8, 2017
@ragnerok ragnerok remove tab and unused code
Signed-off-by: osaid <>
@ragnerok ragnerok calling mockResponse() properly
Signed-off-by: osaid <>
codecov-io commented Jan 8, 2017 edited

Current coverage is 54.21% (diff: 100%)

Merging #12879 into master will not change coverage

@@             master     #12879   diff @@
  Files           465        465          
  Lines         69647      69647          
  Methods        2128       2128          
  Messages          0          0          
  Branches          0          0          
  Hits          37758      37758          
  Misses        31889      31889          
  Partials          0          0          

Powered by Codecov. Last update b40e9c1...cef6c51


test/libraries/core/PMA_headerLocation_test.php - done already

@nijel nijel self-assigned this Jan 18, 2017
@nijel nijel merged commit ffb2856 into phpmyadmin:master Jan 18, 2017

4 checks passed

Scrutinizer 3 updated code elements
codecov/patch Coverage not affected when comparing b40e9c1...cef6c51
codecov/project 54.21% (+0.00%) compared to b40e9c1
continuous-integration/travis-ci/pr The Travis CI build passed
@nijel nijel added this to the 4.7.0 milestone Jan 18, 2017
nijel commented Jan 18, 2017

Merged, thanks for your contribution!

@ragnerok ragnerok deleted the ragnerok:patch branch Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment