Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use shared response mock #12879

Merged
merged 3 commits into from
Jan 18, 2017
Merged

use shared response mock #12879

merged 3 commits into from
Jan 18, 2017

Conversation

osaid-r
Copy link
Contributor

@osaid-r osaid-r commented Jan 8, 2017

Signed-off-by: osaid osaid.nasir@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Signed-off-by: osaid <osaid.nasir@gmail.com>
Signed-off-by: osaid <osaid.nasir@gmail.com>
Signed-off-by: osaid <osaid.nasir@gmail.com>
@codecov-io
Copy link

codecov-io commented Jan 8, 2017

Current coverage is 54.21% (diff: 100%)

Merging #12879 into master will not change coverage

@@             master     #12879   diff @@
==========================================
  Files           465        465          
  Lines         69647      69647          
  Methods        2128       2128          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          37758      37758          
  Misses        31889      31889          
  Partials          0          0          

Powered by Codecov. Last update b40e9c1...cef6c51

@osaid-r
Copy link
Contributor Author

osaid-r commented Jan 11, 2017

test/libraries/core/PMA_headerLocation_test.php - done already

@nijel nijel self-assigned this Jan 18, 2017
@nijel nijel merged commit ffb2856 into phpmyadmin:master Jan 18, 2017
@nijel nijel added this to the 4.7.0 milestone Jan 18, 2017
@nijel
Copy link
Contributor

nijel commented Jan 18, 2017

Merged, thanks for your contribution!

@osaid-r osaid-r deleted the patch branch January 18, 2017 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants