Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated jQuery calls. #13174

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Replaced deprecated jQuery calls. #13174

merged 1 commit into from
Apr 10, 2017

Conversation

udan11
Copy link
Contributor

@udan11 udan11 commented Apr 10, 2017

'bind' and 'unbind', 'delegate' and 'undelegate' have been deprecated in
favor of 'on' and 'off'.

Partially fixes #13166.

Signed-off-by: Dan Ungureanu udan1107@gmail.com

'bind' and 'unbind', 'delegate' and 'undelegate' have been deprecated in
favor of 'on' and 'off'.

Partially fixes #13166.

Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
@codecov
Copy link

codecov bot commented Apr 10, 2017

Codecov Report

Merging #13174 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13174      +/-   ##
==========================================
+ Coverage   54.45%   54.51%   +0.05%     
==========================================
  Files         469      469              
  Lines       69821    69552     -269     
==========================================
- Hits        38023    37915     -108     
+ Misses      31798    31637     -161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dedc3d...1ca19f0. Read the comment docs.

@nijel nijel merged commit db87fa8 into master Apr 10, 2017
@nijel
Copy link
Contributor

nijel commented Apr 10, 2017

Looks good.

@nijel nijel deleted the fix_13166 branch April 10, 2017 10:51
@nijel
Copy link
Contributor

nijel commented Apr 10, 2017

PS: I think it's better if you do feature branch in your repo and open pull request from there. This way we avoid distributing (temporary) feature branches to other phpmyadmin repository forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jQuery Migrate shows 5 warnings in the console
2 participants