Fixed the invalid link which was suggested after an import timeout. #13190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## QA_4_7 #13190 +/- ##
=========================================
+ Coverage 54.28% 54.39% +0.1%
=========================================
Files 466 466
Lines 69736 69311 -425
=========================================
- Hits 37859 37703 -156
+ Misses 31877 31608 -269 |
|
I don't like this change, it will make all URLs end with ? what looks weird. |
Fixes #13189. Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
|
How about constructing the URL from the parameters instead? I've tried to do that in #13364 |
|
Merged #13364 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13189.
The faulty line here is this.
&timeout_passed=1&offset=Zis being appended to one the following possible values of$err_url:tbl_import.php?db=X&table=Y,db_import.php?db=Xorserver_import.phpis appended. This causes an issue when$err_urlis simplyserver_import.php.Signed-off-by: Dan Ungureanu udan1107@gmail.com