Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember status of PMA's navigation bar. #13461

Closed
wants to merge 1 commit into from
Closed

Remember status of PMA's navigation bar. #13461

wants to merge 1 commit into from

Conversation

udan11
Copy link
Contributor

@udan11 udan11 commented Jul 9, 2017

Fixes #13397.

Signed-off-by: Dan Ungureanu udan1107@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Fixes #13397.

Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
@codecov
Copy link

codecov bot commented Jul 9, 2017

Codecov Report

Merging #13461 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13461      +/-   ##
==========================================
+ Coverage   54.48%   54.48%   +<.01%     
==========================================
  Files         468      468              
  Lines       70435    70437       +2     
==========================================
+ Hits        38377    38379       +2     
  Misses      32058    32058

@nijel
Copy link
Contributor

nijel commented Jul 10, 2017

I really think we should not use one cookie per setting. This really doesn't scale. What I'd really prefer is to have some generic solution to store such configuration as there will be probably more things where such persistence makes sense. Preferably having this in the user configuration and having API to change that in javascript, I've created #13466 for this.

See also #13422 (comment) and #11688.

@nijel nijel self-assigned this Jul 10, 2017
@stale stale bot added the wontfix label Sep 8, 2017
@stale
Copy link

stale bot commented Sep 8, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hide side menu in standard
2 participants