Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PhpMyAdmin\Database\Search class #13870

Merged
merged 5 commits into from Dec 17, 2017
Merged

Refactor PhpMyAdmin\Database\Search class #13870

merged 5 commits into from Dec 17, 2017

Conversation

MauricioFauth
Copy link
Member

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

@MauricioFauth
Use template for _getResultsRow method
3010b27 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@MauricioFauth
Use template for getResultDivs method
0e82a5e 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@MauricioFauth
Remove underscores from methods and properties names
fe91ba1 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@MauricioFauth
Use template for getSelectionForm method
aa48445 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@MauricioFauth
Use template for getSearchResults method
f9e4a1c 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@MauricioFauth MauricioFauth added this to the 4.8.0 milestone Dec 17, 2017
@MauricioFauth MauricioFauth self-assigned this Dec 17, 2017
@MauricioFauth MauricioFauth merged commit 142c8ca into phpmyadmin:master Dec 17, 2017
@MauricioFauth MauricioFauth deleted the db-search branch December 17, 2017 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MauricioFauth MauricioFauth

Labels
None yet
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MauricioFauth