New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PhpMyAdmin\Database\Search class #13870

Merged
merged 5 commits into from Dec 17, 2017

Conversation

Projects
None yet
1 participant
@mauriciofauth
Member

mauriciofauth commented Dec 17, 2017

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

mauriciofauth added some commits Dec 15, 2017

Use template for _getResultsRow method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for getResultDivs method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Remove underscores from methods and properties names
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for getSelectionForm method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for getSearchResults method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Dec 17, 2017

@mauriciofauth mauriciofauth self-assigned this Dec 17, 2017

@mauriciofauth mauriciofauth merged commit 142c8ca into phpmyadmin:master Dec 17, 2017

2 of 4 checks passed

Codacy/PR Quality Review Not so good... This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 5 updated code elements – Tests: passed
Details

@mauriciofauth mauriciofauth deleted the mauriciofauth:db-search branch Dec 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment