Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assertNotSame instead of comparison in test #13936

Merged
merged 1 commit into from Jan 16, 2018
Merged

Use assertNotSame instead of comparison in test #13936

merged 1 commit into from Jan 16, 2018

Conversation

carusogabriel
Copy link
Contributor

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
@MauricioFauth MauricioFauth merged commit 7ce0025 into phpmyadmin:master Jan 16, 2018
@MauricioFauth MauricioFauth self-assigned this Jan 16, 2018
@MauricioFauth MauricioFauth added this to the 4.8.0 milestone Jan 16, 2018
@MauricioFauth
Copy link
Member

Merged, thanks for your contribution!

@carusogabriel carusogabriel deleted the assertions branch January 16, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants