Console and Error Report files modularized #14466
Conversation
Piyush3079
force-pushed
the
Mod_Js_Console
branch
from
48e5afd
to
33239b3
Compare
Codecov Report
@@ Coverage Diff @@
## gsoc-js-refactoring #14466 +/- ##
=========================================================
- Coverage 50.53% 49.88% -0.66%
Complexity 14434 14434
=========================================================
Files 501 504 +3
Lines 68006 68895 +889
=========================================================
Hits 34369 34369
- Misses 33637 34526 +889 |
Piyush3079
force-pushed
the
Mod_Js_Console
branch
4 times, most recently
from
e186ba5
to
77b9d15
Compare
Piyush3079
force-pushed
the
Mod_Js_Console
branch
from
4dd06f4
to
ae5e997
Compare
| * This function needs to be changes as no objects are available | ||
| * in the global scope so window does not contain any function | ||
| */ | ||
| wrap_global_functions: function () { |
There was a problem hiding this comment.
Functions are now not available in global scope, therefore need to find some alternate way to wrap exported functions in ErrorReport object and call all the functions in the context of ErrorReport.
| @@ -0,0 +1,338 @@ | |||
| /** | |||
There was a problem hiding this comment.
This file is not in working state completely because of some issues with webpack output files.
- The output is the uglified file, therefore the stack trace is not that clear as it was earlier.
- Due to cross-origin file loading in developer mode, context will not be available in developer mode.
There was a problem hiding this comment.
Do you foresee this working in near future? can something like sourcemaps or something be used to improve this?
There was a problem hiding this comment.
Yeah, source maps can help but there is already an issue on tracekit occ/TraceKit#61 for adding support of source maps. Also, source maps increase the size of output to almost 2.5 times.
I am still looking for ways to deal with this.
Piyush3079
force-pushed
the
Mod_Js_Console
branch
4 times, most recently
from
b949ce8
to
6aeb531
Compare
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
TODO: To find a way to wrap the exported functions containing PMA_ prefix into the error handler to generate backtrace. Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
Piyush3079
force-pushed
the
Mod_Js_Console
branch
2 times, most recently
from
2df0f07
to
de78e79
Compare
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
|
Everything except the selenium job is passing at https://travis-ci.org/phpmyadmin/phpmyadmin/builds/408533738. Merging this to unblock #14467 |
This pr contains the PMA Console and PMA Error Report code in the modular form. The old files were split into multiple files to separate out functions required for base functionality.
There is some issue with this pr.
1). Earlier all the global functions were wrapped in the context of ErrorReport but now due to js modules it will not be possible to wrap all the imports in the context of ErrorReport.
2). Cross-origin files are now not allowed in Tracekit so stacktrace cannot be generated in developer mode.
3). The stack trace generated will contain a single line with column number because of uglified js file as output. See Tracekit Issue: occ/TraceKit#61
This pr is in continuations of Mod_Js_Server_Privileges. Before reviewing this pr, review Mod_Js_Server_Privileges and merge and then compare with this pr.
Before submitting pull request, please check that every commit: