Functional Tests Updated #1448
Functional Tests Updated #1448
Conversation
Signed-off-by: Deven Bhooshan <devenbhooshan@gmail.com>
|
why the selenium tests skipped ? |
|
We had timing issues with Selenium tests on Travis, see |
|
But tests skipped only when the following variables in the configuration file are not set. I didn't understand it. |
|
@devenbhooshan The tests are getting skipped because BrowserStack credentials are secure environment variables which is not made available to pull requests due to security restrictions by Travis. Please see links below which explains it. http://docs.travis-ci.com/user/pull-requests/ |
|
So how should I run my changed tests on Travis? |
|
You have to run it locally on your machine. |
|
I have run the tests on my machine already. I mean to say how are you guys going to moderate my changed tests? I want to contribute in the functional tests. So if I write some tests and I make a pull request for that , then how are you guys going to see whether the tests written by me are correct or not ? |
|
@devenbhooshan We will test your changes locally at our end. |
|
So I have changed some tests in this pr . Please review them locally . |
|
Selenium test job: https://travis-ci.org/D-storm/phpmyadmin/jobs/46214799 |
| $this->byId("buttonGo")->click(); | ||
| $this->byXPath( | ||
| "//*[contains(text(), 'OK')]" |
There was a problem hiding this comment.
I think that a more specific XPath here will be good as this will select all tags containing text "OK" and will attempt to click it.
|
ok. I will change the tests. Thanks for your comment :) |
|
Closing this as of now. |
Signed-off-by: Deven Bhooshan devenbhooshan@gmail.com
Tests have been updated in according to the changes like https://sourceforge.net/p/phpmyadmin/bugs/4684/
Now only few errors will come while running the functional tests.