New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize JS files related to 'structure' #14524

Merged
merged 3 commits into from Aug 9, 2018

Conversation

Projects
None yet
2 participants
@Piyush3079
Contributor

Piyush3079 commented Jul 25, 2018

This pr contains the structured code of javascript.

This pr is in continuation of Mod_Js_Config_Js, Before reviewing this pr, review and merge Mod_Js_Config_Js and then review this pr.
Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

@devenbansod devenbansod changed the base branch from master to gsoc-js-refactoring Aug 1, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 5, 2018

Codecov Report

Merging #14524 into gsoc-js-refactoring will not change coverage.
The diff coverage is 100%.

@@                  Coverage Diff                   @@
##             gsoc-js-refactoring   #14524   +/-   ##
======================================================
  Coverage                  50.53%   50.53%           
  Complexity                 14434    14434           
======================================================
  Files                        501      501           
  Lines                      68012    68012           
======================================================
  Hits                       34372    34372           
  Misses                     33640    33640

codecov bot commented Aug 5, 2018

Codecov Report

Merging #14524 into gsoc-js-refactoring will not change coverage.
The diff coverage is 100%.

@@                  Coverage Diff                   @@
##             gsoc-js-refactoring   #14524   +/-   ##
======================================================
  Coverage                  50.53%   50.53%           
  Complexity                 14434    14434           
======================================================
  Files                        501      501           
  Lines                      68012    68012           
======================================================
  Hits                       34372    34372           
  Misses                     33640    33640

@devenbansod devenbansod self-assigned this Aug 7, 2018

@devenbansod devenbansod self-requested a review Aug 7, 2018

Test files changed as per the new chages in FormDisplayTemplate.
Js code is stuctured properly with comments.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@devenbansod

LGTM.

Just a few minor comments.

Show outdated Hide outdated js/src/export.js
Show outdated Hide outdated js/src/classes/ErrorReport.js

Piyush3079 added some commits Jun 29, 2018

Some more javascript files structured properly.
Shortcut handler and page settings js files added in modular code.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Use import * for files.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@devenbansod

A lot of methods still have the PMA_ prefix, but we can tackle that at the end.

@devenbansod devenbansod merged commit 24f91b1 into phpmyadmin:gsoc-js-refactoring Aug 9, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
DCO All commits have a DCO sign-off from the author
Details

@devenbansod devenbansod changed the title from Mod js structuring 1 to Modularize JS files related to 'structure' Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment