Modularize JS files related to 'structure' #14524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piyush3079
force-pushed
the
Mod_Js_Structuring_1
branch
from
56e5564
to
ad840df
Compare
Codecov Report
@@ Coverage Diff @@
## gsoc-js-refactoring #14524 +/- ##
======================================================
Coverage 50.53% 50.53%
Complexity 14434 14434
======================================================
Files 501 501
Lines 68012 68012
======================================================
Hits 34372 34372
Misses 33640 33640 |
Piyush3079
force-pushed
the
Mod_Js_Structuring_1
branch
8 times, most recently
from
2fc6039
to
d90b2f0
Compare
4 tasks
Js code is stuctured properly with comments. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Piyush3079
force-pushed
the
Mod_Js_Structuring_1
branch
from
d90b2f0
to
2e529f4
Compare
devenbansod
approved these changes
Aug 9, 2018
js/src/export.js
Outdated
| * Module import | ||
| */ | ||
| import { | ||
| createTemplate, |
js/src/classes/ErrorReport.js
Outdated
| @@ -4,7 +4,7 @@ | |||
| */ | |||
| import { AJAX } from '../ajax'; | |||
| import { PMA_Messages as PMA_messages } from '../variables/export_variables'; | |||
| import { PMA_commonParams } from '../variables/common_params'; | |||
| import PMA_commonParams from '../variables/common_params'; | |||
There was a problem hiding this comment.
Why is this PMA_commonParams while it is changed at https://github.com/phpmyadmin/phpmyadmin/pull/14524/files#diff-340666e1d3cfc56d0064172a52016d98R10?
Piyush3079
force-pushed
the
Mod_Js_Structuring_1
branch
from
e051e1e
to
c0810f9
Compare
Shortcut handler and page settings js files added in modular code. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
devenbansod
approved these changes
Aug 9, 2018
devenbansod
changed the title
|
@devenbansod I want to work on this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr contains the structured code of javascript.
This pr is in continuation of Mod_Js_Config_Js, Before reviewing this pr, review and merge Mod_Js_Config_Js and then review this pr.
Before submitting pull request, please check that every commit: