New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_div_for_slider_effect twig extension #14557

Merged
merged 1 commit into from Aug 11, 2018

Conversation

Projects
None yet
2 participants
@laps15
Contributor

laps15 commented Aug 9, 2018

Signed-off-by: Leonardo Strozzi laps15@inf.ufpr.br

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Remove get_div_for_slider_effect twig extension
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 9, 2018

Codecov Report

Merging #14557 into master will decrease coverage by <.01%.
The diff coverage is 20%.

@@             Coverage Diff              @@
##             master   #14557      +/-   ##
============================================
- Coverage     50.03%   50.03%   -0.01%     
  Complexity    14434    14434              
============================================
  Files           498      498              
  Lines         67336    67337       +1     
============================================
- Hits          33693    33690       -3     
- Misses        33643    33647       +4

codecov bot commented Aug 9, 2018

Codecov Report

Merging #14557 into master will decrease coverage by <.01%.
The diff coverage is 20%.

@@             Coverage Diff              @@
##             master   #14557      +/-   ##
============================================
- Coverage     50.03%   50.03%   -0.01%     
  Complexity    14434    14434              
============================================
  Files           498      498              
  Lines         67336    67337       +1     
============================================
- Hits          33693    33690       -3     
- Misses        33643    33647       +4

@mauriciofauth mauriciofauth merged commit af5d083 into phpmyadmin:master Aug 11, 2018

5 of 7 checks passed

codecov/patch 20% of diff hit (target 50.03%)
Details
codecov/project 50.03% (-0.01%) compared to 1d39152
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this Aug 11, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Aug 11, 2018

@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Aug 11, 2018

Member

Merged, thanks for your contribution!

Member

mauriciofauth commented Aug 11, 2018

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment