Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular code for table structure and table related files #14564

Merged
merged 17 commits into from Aug 19, 2018

Conversation

Projects
None yet
3 participants
@Piyush3079
Copy link
Contributor

Piyush3079 commented Aug 12, 2018

This pr contains the modular code for table-related files.

This pr is in continuation with the pr Mod_Js_Db_Structure. Before reviewing this pr, review and merge Mod_Js_Db_Structure and then start reviewing this.

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@phpmyadmin-bot

This comment has been minimized.

Copy link

phpmyadmin-bot commented Aug 12, 2018

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@Piyush3079 Piyush3079 force-pushed the Piyush3079:Mod_Js_Tbl_Structure branch 2 times, most recently from 91a5fd2 to d657991 Aug 14, 2018

@phpmyadmin-bot

This comment has been minimized.

Copy link

phpmyadmin-bot commented Aug 15, 2018

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@Piyush3079 Piyush3079 force-pushed the Piyush3079:Mod_Js_Tbl_Structure branch 2 times, most recently from 91a5fd2 to 7daada9 Aug 15, 2018

@phpmyadmin-bot

This comment has been minimized.

Copy link

phpmyadmin-bot commented Aug 17, 2018

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #14564 into gsoc-js-refactoring will increase coverage by 0.01%.
The diff coverage is 10.52%.

@@                    Coverage Diff                    @@
##             gsoc-js-refactoring   #14564      +/-   ##
=========================================================
+ Coverage                  50.57%   50.58%   +0.01%     
  Complexity                 14442    14442              
=========================================================
  Files                        501      501              
  Lines                      67999    67983      -16     
=========================================================
  Hits                       34388    34388              
+ Misses                     33611    33595      -16

@Piyush3079 Piyush3079 force-pushed the Piyush3079:Mod_Js_Tbl_Structure branch 2 times, most recently from 91a5fd2 to 7daada9 Aug 17, 2018

@phpmyadmin-bot

This comment has been minimized.

Copy link

phpmyadmin-bot commented Aug 17, 2018

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@Piyush3079 Piyush3079 changed the base branch from master to gsoc-js-refactoring Aug 17, 2018

@Piyush3079 Piyush3079 force-pushed the Piyush3079:Mod_Js_Tbl_Structure branch from 7daada9 to 8d5e968 Aug 17, 2018

@devenbansod

This comment has been minimized.

Copy link
Member

devenbansod commented Aug 19, 2018

@Piyush3079 please rebase

@devenbansod devenbansod self-requested a review Aug 19, 2018

@devenbansod devenbansod self-assigned this Aug 19, 2018

@Piyush3079 Piyush3079 force-pushed the Piyush3079:Mod_Js_Tbl_Structure branch from 8d5e968 to cec4a3c Aug 19, 2018

Add PMA_showHints function in show_ajax_messages.js in js/src/utils a…
…nd PMA_initSlider in Slider.js.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

@Piyush3079 Piyush3079 force-pushed the Piyush3079:Mod_Js_Tbl_Structure branch from cec4a3c to 0a43e91 Aug 19, 2018

@phpmyadmin-bot

This comment has been minimized.

Copy link

phpmyadmin-bot commented on 2558661 Aug 19, 2018

This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: js/src/ajax.js

@Piyush3079 Piyush3079 force-pushed the Piyush3079:Mod_Js_Tbl_Structure branch from 0a43e91 to 0ce9714 Aug 19, 2018

Piyush3079 added some commits Jul 30, 2018

Modular code for indexes.js being used on different pages.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Remove .js extension from php files for indexes.js to allow dynami im…
…port.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Modular code for tbl_structure.js
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Remove .js extension from tbl_structure.php related files to allow dy…
…namic imports.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Modular code for tbl_relation.php.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Remove .js extension from tbl_relation.php related files for dynamic …
…loading.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Modular code for tbl_chart for dawing charts on Table Browsing
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Remove .js extension from files and remove jqplot plugins which are n…
…ot deened to be loaded in head of page.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Modular code for tbl_operations.php
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Piyush3079 added some commits Aug 1, 2018

Remove .js extention from tbl_operations.php file to allow dynamic im…
…port.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Modular code for tbl_tracking.php
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Modular code for tbl_change.php.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Edit php files for changes related to tbl_change.js
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Modular code for tbl_select.js
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
Modular code for tbl_find_replace.php
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

@Piyush3079 Piyush3079 changed the title Mod js tbl structure Modular code for table structure and table related files Aug 19, 2018

@devenbansod
Copy link
Member

devenbansod left a comment

Tested locally. LGTM.

A few minor comments.

});
}
}
// /*

This comment has been minimized.

@devenbansod

devenbansod Aug 19, 2018

Member

/minor remove if not needed?

}
});
// /**
// * Unbind all event handlers before tearing down a page

This comment has been minimized.

@devenbansod

devenbansod Aug 19, 2018

Member

same as above

@@ -772,6 +772,40 @@ export let AJAX = {
$(document).on('click', 'a', AJAX.requestHandler);
$(document).on('submit', 'form', AJAX.requestHandler);

/**
* @todo this is to be removed when complete code is modularised * Gracefully handle fatal server errors

This comment has been minimized.

@devenbansod
@@ -244,16 +243,15 @@ public function indexAction()
->getScripts()
->addFiles(
[
'makegrid.js',
'sql.js',
'sql',
'vendor/jqplot/jquery.jqplot.js',

This comment has been minimized.

@devenbansod

devenbansod Aug 19, 2018

Member

Are these still needed to be added explicitly?

This comment has been minimized.

@Piyush3079

Piyush3079 Aug 19, 2018

Author Contributor

Yeah they were sending the scripts list in ajax response but scripts were loaded by dynamic imports only.

@Piyush3079 Piyush3079 force-pushed the Piyush3079:Mod_Js_Tbl_Structure branch 2 times, most recently from 37ac9a3 to 5f4db91 Aug 19, 2018

Resolve merge conflicts and add tbl import and export in modular code
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

@devenbansod devenbansod merged commit d031dec into phpmyadmin:gsoc-js-refactoring Aug 19, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
DCO All commits have a DCO sign-off from the author
Details

@Piyush3079 Piyush3079 deleted the Piyush3079:Mod_Js_Tbl_Structure branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.