Modular code for table structure and table related files #14564

Piyush3079 · 2018-08-12T22:19:38Z

This pr contains the modular code for table-related files.

This pr is in continuation with the pr Mod_Js_Db_Structure. Before reviewing this pr, review and merge Mod_Js_Db_Structure and then start reviewing this.

Before submitting pull request, please check that every commit:

Has proper Signed-Off-By
Has commit message which describes it
Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
Any new functionality is covered by tests

phpmyadmin-bot · 2018-08-12T22:19:40Z

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

phpmyadmin-bot · 2018-08-15T04:34:25Z

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

phpmyadmin-bot · 2018-08-17T08:50:59Z

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

codecov · 2018-08-17T08:51:05Z

Codecov Report

Merging #14564 into gsoc-js-refactoring will increase coverage by 0.01%.
The diff coverage is 10.52%.

@@                    Coverage Diff                    @@
##             gsoc-js-refactoring   #14564      +/-   ##
=========================================================
+ Coverage                  50.57%   50.58%   +0.01%     
  Complexity                 14442    14442              
=========================================================
  Files                        501      501              
  Lines                      67999    67983      -16     
=========================================================
  Hits                       34388    34388              
+ Misses                     33611    33595      -16

phpmyadmin-bot · 2018-08-17T08:53:55Z

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

devenbansod · 2018-08-19T04:31:44Z

@Piyush3079 please rebase

…nd PMA_initSlider in Slider.js. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

…port. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

…namic imports. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

…loading. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

…ot deened to be loaded in head of page. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

…port. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

devenbansod

Tested locally. LGTM.

A few minor comments.

devenbansod · 2018-08-19T09:38:55Z

js/functions.js

-        });
-    }
-}
+// /*


/minor remove if not needed?

devenbansod · 2018-08-19T09:39:07Z

js/functions.js

-    }
-});
+// /**
+//  * Unbind all event handlers before tearing down a page


same as above

devenbansod · 2018-08-19T09:39:30Z

js/src/ajax.js

@@ -772,6 +772,40 @@ export let AJAX = {
 $(document).on('click', 'a', AJAX.requestHandler);
 $(document).on('submit', 'form', AJAX.requestHandler);

+/**
+ * @todo this is to be removed when complete code is modularised	 * Gracefully handle fatal server errors


devenbansod · 2018-08-19T09:41:25Z

libraries/classes/Controllers/Table/TableSearchController.php

@@ -244,16 +243,15 @@ public function indexAction()
                ->getScripts()
                ->addFiles(
                    [
-                        'makegrid.js',
-                        'sql.js',
+                        'sql',
                        'vendor/jqplot/jquery.jqplot.js',


Are these still needed to be added explicitly?

Yeah they were sending the scripts list in ajax response but scripts were loaded by dynamic imports only.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Piyush3079 force-pushed the Mod_Js_Tbl_Structure branch 2 times, most recently from 91a5fd2 to d657991 Compare August 15, 2018 04:34

Piyush3079 force-pushed the Mod_Js_Tbl_Structure branch 2 times, most recently from 91a5fd2 to 7daada9 Compare August 17, 2018 08:50

Piyush3079 force-pushed the Mod_Js_Tbl_Structure branch 2 times, most recently from 91a5fd2 to 7daada9 Compare August 17, 2018 08:53

Piyush3079 changed the base branch from master to gsoc-js-refactoring August 17, 2018 08:54

Piyush3079 force-pushed the Mod_Js_Tbl_Structure branch from 7daada9 to 8d5e968 Compare August 17, 2018 08:57

devenbansod self-requested a review August 19, 2018 04:31

devenbansod self-assigned this Aug 19, 2018

Piyush3079 force-pushed the Mod_Js_Tbl_Structure branch from 8d5e968 to cec4a3c Compare August 19, 2018 07:54

Add PMA_showHints function in show_ajax_messages.js in js/src/utils a…

2558661

…nd PMA_initSlider in Slider.js. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Piyush3079 force-pushed the Mod_Js_Tbl_Structure branch 2 times, most recently from 0a43e91 to 0ce9714 Compare August 19, 2018 08:13

Piyush3079 added 10 commits August 19, 2018 13:43

Modular code for indexes.js being used on different pages.

3e8e825

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Remove .js extension from php files for indexes.js to allow dynami im…

17958e8

…port. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Modular code for tbl_structure.js

aebde04

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Remove .js extension from tbl_structure.php related files to allow dy…

8351907

…namic imports. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Modular code for tbl_relation.php.

d521643

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Remove .js extension from tbl_relation.php related files for dynamic …

8ac17c0

…loading. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Modular code for tbl_chart for dawing charts on Table Browsing

f6b5d2d

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Remove .js extension from files and remove jqplot plugins which are n…

0e44376

…ot deened to be loaded in head of page. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Modular code for tbl_operations.php

dcad9d0

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Remove .js extention from tbl_operations.php file to allow dynamic im…

302eaf5

…port. Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Piyush3079 added 5 commits August 19, 2018 13:44

Modular code for tbl_tracking.php

5647d8c

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Modular code for tbl_change.php.

0f7a7c3

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Edit php files for changes related to tbl_change.js

c1f6c86

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Modular code for tbl_select.js

65a54b8

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Modular code for tbl_find_replace.php

0ce9714

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

Piyush3079 changed the title ~~Mod js tbl structure~~ Modular code for table structure and table related files Aug 19, 2018

devenbansod approved these changes Aug 19, 2018

View reviewed changes

Piyush3079 force-pushed the Mod_Js_Tbl_Structure branch 2 times, most recently from 37ac9a3 to 5f4db91 Compare August 19, 2018 09:59

Resolve merge conflicts and add tbl import and export in modular code

5f4db91

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>

devenbansod merged commit d031dec into phpmyadmin:gsoc-js-refactoring Aug 19, 2018

Piyush3079 deleted the Mod_Js_Tbl_Structure branch August 28, 2018 11:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modular code for table structure and table related files #14564

Modular code for table structure and table related files #14564

Piyush3079 commented Aug 12, 2018

phpmyadmin-bot commented Aug 12, 2018

phpmyadmin-bot commented Aug 15, 2018

phpmyadmin-bot commented Aug 17, 2018

codecov bot commented Aug 17, 2018 •

edited

Loading

phpmyadmin-bot commented Aug 17, 2018

devenbansod commented Aug 19, 2018

devenbansod left a comment

devenbansod Aug 19, 2018

devenbansod Aug 19, 2018

devenbansod Aug 19, 2018

devenbansod Aug 19, 2018

Piyush3079 Aug 19, 2018

Modular code for table structure and table related files #14564

Modular code for table structure and table related files #14564

Conversation

Piyush3079 commented Aug 12, 2018

phpmyadmin-bot commented Aug 12, 2018

phpmyadmin-bot commented Aug 15, 2018

phpmyadmin-bot commented Aug 17, 2018

codecov bot commented Aug 17, 2018 • edited Loading

Codecov Report

phpmyadmin-bot commented Aug 17, 2018

devenbansod commented Aug 19, 2018

devenbansod left a comment

Choose a reason for hiding this comment

devenbansod Aug 19, 2018

Choose a reason for hiding this comment

devenbansod Aug 19, 2018

Choose a reason for hiding this comment

devenbansod Aug 19, 2018

Choose a reason for hiding this comment

devenbansod Aug 19, 2018

Choose a reason for hiding this comment

Piyush3079 Aug 19, 2018

Choose a reason for hiding this comment

codecov bot commented Aug 17, 2018 •

edited

Loading