Fix several issues with table headers in Safari #14589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The width += 1 does not apply to Safari, either. Safari requires min-width and max-width to be set. “width” is not honored. Add a line break to template so comments stay on separate line. Moved browser checks to higher scope; the user agent only needs to be checked once, not once per cell. Signed-off-by: Bob Terrell <bob.terrell@acordex.com>
btacordex
force-pushed
the
fix-table-headers-safari
branch
from
1576a9d
to
0861e05
Compare
Codecov Report
@@ Coverage Diff @@
## master #14589 +/- ##
=========================================
Coverage 49.7% 49.7%
Complexity 13936 13936
=========================================
Files 498 498
Lines 66843 66843
=========================================
Hits 33221 33221
Misses 33622 33622 |
|
Thanks for researching this and contributing a fix! Even though the Safari issue affects the current 4.8 branch, I think I'll merge this only in to master (which will become version 5.0) as it does change the look of the comments. |
|
Merged, thanks for your contribution! This will be a part of version 5.0 when it comes out. |
ibennetch
added a commit
that referenced
this pull request
Aug 28, 2018
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The width += 1 does not apply to Safari, either.
Safari requires min-width and max-width to be set. “width” is not honored.
Add a line break to template so comments stay on separate line.
Moved browser checks to higher scope; the user agent only needs to be checked once, not once per cell.
Before submitting pull request, please check that every commit: