Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugs#3935 Table Header issue in Safari 5.0.5 #1471

Closed
wants to merge 1 commit into from
Closed

bugs#3935 Table Header issue in Safari 5.0.5 #1471

wants to merge 1 commit into from

Conversation

whitepiegon
Copy link
Contributor

Signed-off-by: Aayush Anand aayushism12@gmail.com

Signed-off-by: Aayush Anand <aayushism12@gmail.com>
@whitepiegon
Copy link
Contributor Author

This bug was occurring due to $col.outerWidth(true).
In safari 5.0.5 $col.outerWidth(true) apart from returning the width, it was also extending the width. On the other hand $col.outerWidth() is working fine for safari.
However, I did not change it for other browser as jquery 1.8 require .outerWidth with argument for includeMargin.
Please check if my fix works well for other versions of safari.

@lem9
Copy link
Contributor

lem9 commented Feb 2, 2015

Thanks. Could you resubmit a pull request on QA_4_3 (because 4.2 is outdated). And avoid using tab characters.

@lem9 lem9 closed this Feb 2, 2015
@whitepiegon
Copy link
Contributor Author

thanks.. here it is.. #1473
but i don't know why the The Travis CI build failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants