Extract HTML from view_operations.php to a Twig template #14836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thiago Colares <thicolares@gmail.com>
…late Signed-off-by: Thiago Colares <thicolares@gmail.com>
|
The Travis CI build failed. I'm going to check this out in a few minutes |
Signed-off-by: Thiago Colares <thicolares@gmail.com> Signed-off-by: Thiago Colares <thicolares@gmail.com>
thicolares
force-pushed
the
extract-html-in-view-operations-to-twig
branch
from
1808108
to
742f87e
Compare
williamdes
approved these changes
Jan 9, 2019
MauricioFauth
requested changes
Jan 10, 2019
There was a problem hiding this comment.
Hi, @thicolares. Thanks for your contribution.
Could you rename the template to templates/table/operations/view.twig?
Signed-off-by: Thiago Colares <thicolares@gmail.com>
Signed-off-by: Thiago Colares <thicolares@gmail.com>
Signed-off-by: Thiago Colares <thicolares@gmail.com>
Signed-off-by: Thiago Colares <thicolares@gmail.com>
Signed-off-by: Thiago Colares <thicolares@gmail.com>
…thicolares/phpmyadmin into extract-html-in-view-operations-to-twig Signed-off-by: Thiago Colares <thicolares@gmail.com>
thicolares
force-pushed
the
extract-html-in-view-operations-to-twig
branch
from
213e826
to
dbd674b
Compare
Codecov Report
@@ Coverage Diff @@
## master #14836 +/- ##
============================================
+ Coverage 50.87% 50.89% +0.01%
Complexity 14033 14033
============================================
Files 473 473
Lines 65898 65877 -21
============================================
Hits 33525 33525
+ Misses 32373 32352 -21 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #14836 +/- ##
============================================
+ Coverage 50.87% 50.89% +0.01%
Complexity 14033 14033
============================================
Files 473 473
Lines 65898 65877 -21
============================================
Hits 33525 33525
+ Misses 32373 32352 -21 |
MauricioFauth
approved these changes
Jan 11, 2019
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #14801
Before submitting pull request, please review the following checklist:
Signed-off-byline as described in our DCO. This ensures that the work you're submitting is your own creation.