Feature request 1312: Added configuration option for setting the timezone of the current database connection #1495
Conversation
|
This seems reasonable to me but I hope some others developers comment as well. Could you also add this directive to doc/config.rst ? |
|
Sure, I will do this tomorrow. |
| * time zone of your database server. | ||
| * | ||
| * Useful when your database server uses a time zone which is different from the | ||
| * time zone you want to use in PhpMyAdmin. |
There was a problem hiding this comment.
Lines 500 and 501 probably can be removed from libraries/config.default.php and moved to doc/config.rst. We don't need full documentation here; just enough to give hints. Users can always refer to the full documentation if they don't understand a directive.
My suggestion is that here we say "Sets the time zone used by phpMyAdmin. Possible values are explained at http://dev.mysql.com/doc/refman/5.7/en/time-zone-support.html" -- and move the rest of what you wrote to config.rst.
|
The patch seems reasonable to me too. I appreciate the fact that if left empty, the directive will do nothing (we don't want unnecessary queries sent to the MySQL server). |
| ); | ||
|
|
||
| $GLOBALS['error_handler']->addError( | ||
| __($error_message_tz), |
There was a problem hiding this comment.
I'm not 100% sure about this, but don't think this will work properly for translating. Normally you'd do something like sprintf(__('Unable to use...')). That way, gettext can properly format the plural forms and digits.
1 similar comment
|
Thanks. Could you clean up your commits, producing just one? |
…zone of the current database connection. Signed-off-by: Dennis Broeks <dennis@uitzendbureau.nl>
|
Thanks. |
Feature request 1312: Added configuration option for setting the timezone of the current database connection
|
See also 26f7584 |
https://sourceforge.net/p/phpmyadmin/feature-requests/1312/