New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracts HTML from UserPassword.php to twig template #14801 #15610
Conversation
6a8119e
to
c4181e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #15610 +/- ##
============================================
+ Coverage 52.96% 52.96% +<.01%
Complexity 14096 14096
============================================
Files 475 475
Lines 61290 61289 -1
============================================
Hits 32463 32463
+ Misses 28827 28826 -1 |
@williamdes This is my first PR. I do not understand why its failing the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thanks for your contribution.
For now the selenium tests can fail for strange reasons (#15154), just do as if they where not failing ;) |
5bc9c5a
to
1123779
Compare
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
@MauricioFauth I have made the required changes. |
Merged, thanks for your contribution! |
Signed-off-by: Jayati Shrivastava gaurijove@gmail.com
This PR is for extracting HTML from the UserPassword.php to a twig template and continues the work on #14801 .
Before submitting pull request, please review the following checklist:
Signed-off-by
line as described in our DCO. This ensures that the work you're submitting is your own creation.