Added alert message for extensions required #15643

kartik1000 · 2019-12-11T14:30:29Z

Signed-off-by: Kartik Kathuria kathuriakartik0@gmail.com

Description

.
This will add an alert message if the user is trying to import a file with zip extension or bzip2 extension that the required extensions must be present or enabled to import a zip or bzip2 file.

Fixes #15328

Before submitting pull request, please review the following checklist:

Make sure you have read our CONTRIBUTING.md document.
Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
Every commit has a descriptive commit message.
Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
Any new functionality is covered by tests.

js/import.js

templates/display/import/import.twig

codecov · 2020-01-11T18:00:18Z

Codecov Report

Merging #15643 into QA_5_0 will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             QA_5_0   #15643      +/-   ##
============================================
- Coverage     53.05%   53.05%   -0.01%     
  Complexity    14156    14156              
============================================
  Files           482      482              
  Lines         62132    62134       +2     
============================================
  Hits          32965    32965              
- Misses        29167    29169       +2

kartik1000 · 2020-01-11T18:01:25Z

@williamdes, I have made the changes. Please review.

williamdes

Quite good, added some minor changes

libraries/classes/Display/Import.php

templates/display/import/import.twig

kartik1000 · 2020-01-12T07:13:39Z

@williamdes I have made the changes. Please review.

williamdes

💯

williamdes · 2020-01-12T17:13:11Z

@kartik1000 You mentioned #14326 but I see no implementation for the export page

kartik1000 · 2020-01-12T17:15:37Z

Oh, I didn't read it was the same as one of the issues was even mentioned in the other. No , the alert is only for import.

williamdes · 2020-01-12T17:17:05Z

Okay
@MauricioFauth can I please have a review ?

kartik1000 · 2020-02-18T20:29:07Z

@williamdes @MauricioFauth Can we do a review so that we can look to merge this as this was listed as a high priority issue?

williamdes · 2020-02-18T20:35:27Z

@kartik1000 Can you add a bit of JS code to show the error only when compression is selected ?
And also add a back-end check ?

kartik1000 · 2020-02-18T20:41:26Z

@williamdes Ok I will add those checks :)

williamdes

👍
Maybe you need yarn run js-lint --fix

MauricioFauth · 2020-02-24T14:38:40Z

templates/display/import/import.twig

+            {% if extension_bz2 == false %}
+            <div class="formelementrow" id="alert_message_for_bz2">
+                <p>
+                    <strong>{% trans 'Please enable the php bz2 extension to import a php bz2 file else it will result in a blank screen' %}</strong>


I think it's better to fix the blank page instead of showing this message.

I agree, a back-end check + message is required

stale · 2020-06-26T05:39:50Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

See: https://filext.com/file-extension/BZ2 See: https://filext.com/file-extension/ZIP Co-authored-by: William Desportes <williamdes@wdes.fr> Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>

MauricioFauth · 2020-08-16T23:18:39Z

Closed by 51b04c9. Thanks for your contribution.

williamdes reviewed Dec 16, 2019

View reviewed changes

js/import.js Outdated Show resolved Hide resolved

williamdes reviewed Dec 16, 2019

View reviewed changes

templates/display/import/import.twig Outdated Show resolved Hide resolved

williamdes added this to In progress in pull-requests via automation Dec 16, 2019

williamdes moved this from In progress to Review in progress in pull-requests Dec 16, 2019

williamdes changed the base branch from QA_4_9 to QA_5_0 December 26, 2019 19:38

kartik1000 force-pushed the Fix#15328 branch from 172c1a1 to 5096861 Compare January 11, 2020 18:00

williamdes requested changes Jan 11, 2020

View reviewed changes

libraries/classes/Display/Import.php Outdated Show resolved Hide resolved

libraries/classes/Display/Import.php Outdated Show resolved Hide resolved

templates/display/import/import.twig Outdated Show resolved Hide resolved

templates/display/import/import.twig Outdated Show resolved Hide resolved

pull-requests automation moved this from Review in progress to Reviewer approved Jan 12, 2020

williamdes approved these changes Jan 12, 2020

View reviewed changes

williamdes self-assigned this Jan 12, 2020

williamdes added this to the 5.0.2 milestone Jan 12, 2020

williamdes force-pushed the Fix#15328 branch from e285a4a to 807bdaf Compare January 12, 2020 17:11

williamdes approved these changes Feb 20, 2020

View reviewed changes

williamdes requested review from MauricioFauth and ibennetch February 22, 2020 21:54

MauricioFauth requested changes Feb 24, 2020

View reviewed changes

pull-requests automation moved this from Reviewer approved to Review in progress Feb 24, 2020

ibennetch modified the milestones: 5.0.2, 5.0.3 Mar 21, 2020

williamdes force-pushed the Fix#15328 branch from b04ba0c to 3169cb0 Compare April 26, 2020 09:32

stale bot added the wontfix label Jun 26, 2020

williamdes removed the wontfix label Jun 26, 2020

Alerting by checking if extension is loaded or not

1c7a039

See: https://filext.com/file-extension/BZ2 See: https://filext.com/file-extension/ZIP Co-authored-by: William Desportes <williamdes@wdes.fr> Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>

williamdes force-pushed the Fix#15328 branch from 3169cb0 to 1c7a039 Compare August 7, 2020 11:49

MauricioFauth closed this in 51b04c9 Aug 16, 2020

pull-requests automation moved this from Review in progress to Done Aug 16, 2020

MauricioFauth self-assigned this Aug 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added alert message for extensions required #15643

Added alert message for extensions required #15643

kartik1000 commented Dec 11, 2019 •

edited

codecov bot commented Jan 11, 2020 •

edited

kartik1000 commented Jan 11, 2020

williamdes left a comment

kartik1000 commented Jan 12, 2020

williamdes left a comment

williamdes commented Jan 12, 2020

kartik1000 commented Jan 12, 2020

williamdes commented Jan 12, 2020

kartik1000 commented Feb 18, 2020

williamdes commented Feb 18, 2020

kartik1000 commented Feb 18, 2020

williamdes left a comment

MauricioFauth Feb 24, 2020 •

edited

williamdes Feb 24, 2020

stale bot commented Jun 26, 2020

MauricioFauth commented Aug 16, 2020

Added alert message for extensions required #15643

Added alert message for extensions required #15643

Conversation

kartik1000 commented Dec 11, 2019 • edited

Description

codecov bot commented Jan 11, 2020 • edited

Codecov Report

kartik1000 commented Jan 11, 2020

williamdes left a comment

Choose a reason for hiding this comment

kartik1000 commented Jan 12, 2020

williamdes left a comment

Choose a reason for hiding this comment

williamdes commented Jan 12, 2020

kartik1000 commented Jan 12, 2020

williamdes commented Jan 12, 2020

kartik1000 commented Feb 18, 2020

williamdes commented Feb 18, 2020

kartik1000 commented Feb 18, 2020

williamdes left a comment

Choose a reason for hiding this comment

MauricioFauth Feb 24, 2020 • edited

Choose a reason for hiding this comment

williamdes Feb 24, 2020

Choose a reason for hiding this comment

stale bot commented Jun 26, 2020

MauricioFauth commented Aug 16, 2020

kartik1000 commented Dec 11, 2019 •

edited

codecov bot commented Jan 11, 2020 •

edited

MauricioFauth Feb 24, 2020 •

edited