Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed deprecated jquery selectors (Serious changes) #15823

Merged
merged 3 commits into from Jan 22, 2020
Merged

Fixed deprecated jquery selectors (Serious changes) #15823

merged 3 commits into from Jan 22, 2020

Conversation

yashrajbothra
Copy link
Contributor

@yashrajbothra yashrajbothra commented Jan 20, 2020 •
edited by williamdes

Description

(Commit : 98dc941)

  1. :eq has been replaced with .eq()
    Ref: https://api.jquery.com/eq-selector/

(Commit : e13b4aa)

  1. :odd has been replaced with foreach loop which checks and filter odd.
    Ref: https://api.jquery.com/odd-selector/

  2. :even has been replaced with foreach loop which checks and filter even.
    Ref: https://api.jquery.com/even-selector/

(Commit : 5366772)

  1. :nth:child is replaced with this sloution
    Ref: https://api.jquery.com/nth-child-selector

Fixes: #15792

@yashrajbothra
phpmyadmin#15792 Fixed deprecated :eq selector
98dc941 
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@yashrajbothra
phpmyadmin#15792 Fixed deprecated :odd , :even selectors
e13b4aa 
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@yashrajbothra
phpmyadmin#15792 Fixed deprecated :nth-child selector
5366772 
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@williamdes williamdes added this to In progress in pull-requests via automation Jan 20, 2020
@williamdes williamdes moved this from In progress to To merge in pull-requests Jan 20, 2020
@williamdes williamdes added this to the 5.1.0 milestone Jan 20, 2020
pull-requests automation moved this from To merge to Reviewer approved Jan 22, 2020
@williamdes williamdes self-assigned this Jan 22, 2020
@williamdes williamdes added the enhancement A feature request for improving phpMyAdmin label Jan 22, 2020
williamdes added a commit that referenced this pull request Jan 22, 2020
@williamdes
Merge #15823 - Ref #15792 - Fixed deprecated jquery selectors
95eb48f 
Ref: #15792
Pull-request: #15823
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 5366772 into phpmyadmin:master Jan 22, 2020
pull-requests automation moved this from Reviewer approved to Done Jan 22, 2020
@CommanderRoot CommanderRoot mentioned this pull request Dec 13, 2020
Merged
6 tasks
williamdes added a commit that referenced this pull request Dec 13, 2020
@williamdes
Merge #16530 - Ref #15792 - Fixed deprecated jquery selectors and bro…
f476b05 
…ken monitor page

Pull-request: #16530
Ref #15792
Ref: 95eb48f (#15823)

Signed-off-by: William Desportes <williamdes@wdes.fr>
@CommanderRoot CommanderRoot mentioned this pull request Dec 13, 2020
Merged
6 tasks
williamdes added a commit that referenced this pull request Dec 13, 2020
@williamdes
Merge #16531 - Ref #15792 - Fixed deprecated jquery selectors and bro…
51db118 
…ken event scheduler button

Pull-request: #16531
Ref: #15792
Follows: #16530 
Ref: 95eb48f (#15823)

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes mentioned this pull request Apr 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauricioFauth MauricioFauth MauricioFauth approved these changes

@williamdes williamdes williamdes approved these changes

Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin
Projects
pull-requests
  
Done
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

jQuery positional selectors are deprecated
3 participants
@yashrajbothra @MauricioFauth @williamdes