Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Action buttons on join query #15971

Closed
wants to merge 1 commit into from

Conversation

yashrajbothra
Copy link
Contributor

Signed-off-by: Yash Bothra yashrajbothra786@gmail.com

Description

Replaced || with && so just_one_table is only false when there is more than one table

Fixes #13488

@williamdes williamdes self-assigned this Feb 22, 2020
@williamdes williamdes added this to In progress in pull-requests via automation Feb 22, 2020
@williamdes williamdes added this to the 5.0.2 milestone Feb 22, 2020
@williamdes williamdes removed this from the 5.0.2 milestone Feb 22, 2020
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SELECT message.* FROM message JOIN user ON message.user_id = user.id WHERE user.username != '' #12625 (comment)

The fix you made would revert 6b256e8 and 8c357fa for #12625

pull-requests automation moved this from In progress to Review in progress Feb 22, 2020
@stale
Copy link

stale bot commented Apr 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 23, 2020
@stale
Copy link

stale bot commented Jun 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 22, 2020
@williamdes
Copy link
Member

For reference:

// hide edit and delete links:
// - for information_schema
// - if the result set does not contain all the columns of a unique key
// (unless this is an updatable view)
// - if the SELECT query contains a join or a subquery

@MauricioFauth @ibennetch do you think this PR is right or wrong (see above posted comments) ?

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 4, 2020
@williamdes williamdes removed the wontfix label Oct 6, 2020
@williamdes williamdes changed the base branch from QA_5_0 to master November 1, 2020 22:47
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@williamdes williamdes changed the base branch from master to QA_5_1 February 9, 2021 13:11
@williamdes
Copy link
Member

SELECT message.* FROM message JOIN user ON message.user_id = user.id WHERE user.username != '' #12625 (comment)

The fix you made would revert 6b256e8 and 8c357fa for #12625

Hi @devenbansod
Could you give me some advice on this old commit you had done ?

@codecov

This comment has been minimized.

@williamdes
Copy link
Member

cc @ibennetch @MauricioFauth would anyone like to help me unblock this PR ?

@MauricioFauth
Copy link
Member

As William mentioned earlier, this pull request will cause a regression of the bug #12625.

pull-requests automation moved this from Review in progress to Done Apr 21, 2021
@MauricioFauth MauricioFauth self-assigned this Apr 21, 2021
@williamdes williamdes removed this from Done in pull-requests Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot inline edit when a join is used in 4.7.2, works fine in 4.2.5
3 participants