New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Action buttons on join query #15971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SELECT message.* FROM message JOIN user ON message.user_id = user.id WHERE user.username != ''
#12625 (comment)
The fix you made would revert 6b256e8 and 8c357fa for #12625
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
For reference: phpmyadmin/libraries/classes/Sql.php Lines 1860 to 1864 in 7fdde9e
@MauricioFauth @ibennetch do you think this PR is right or wrong (see above posted comments) ? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
7fdde9e
to
64761d5
Compare
Hi @devenbansod |
This comment has been minimized.
This comment has been minimized.
cc @ibennetch @MauricioFauth would anyone like to help me unblock this PR ? |
As William mentioned earlier, this pull request will cause a regression of the bug #12625. |
Signed-off-by: Yash Bothra yashrajbothra786@gmail.com
Description
Replaced
||
with&&
sojust_one_table
is only false when there is more than one tableFixes #13488