Make the console setup async #16590
Merged
Make the console setup async #16590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Desportes <williamdes@wdes.fr>
This comment has been minimized.
This comment has been minimized.
MauricioFauth
approved these changes
Jan 25, 2021
It is fixing slowness for our users and this was reported many times, still okay that I merge this into 5_1 ? |
Go ahead. |
williamdes
added a commit
that referenced
this pull request
Jan 25, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the console setup async to avoid hanging the page waiting for the config to be received
The console can wait.