Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11834 - Fixing the issues regarding granting/showing priv from priv tab #17045

Merged

Conversation

iifawzi
Copy link
Contributor

@iifawzi iifawzi commented Jul 28, 2021

Signed-off-by: Fawzi E. Abdulfattah iifawzie@gmail.com

Description

This PR should fix the mentioned issue in #11834, and also fixes another issue regarding showing the granted users on an uppercased database TEST_DB OR TESTDB, previously, the granted users will not be shown in the privileges tab in that db, because the permissions are stored in lowercase in mysql.db, and we're fetching it uppercased if it's uppercased, I've just lowercased it to get the granted users correctly.

Fixes #11834

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #17045 (3f985e2) into QA_5_1 (c0f62ba) will increase coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             QA_5_1   #17045   +/-   ##
=========================================
  Coverage     57.65%   57.66%           
  Complexity    15307    15307           
=========================================
  Files           471      471           
  Lines         62057    62058    +1     
=========================================
+ Hits          35782    35784    +2     
+ Misses        26275    26274    -1     
Flag Coverage Δ
arch-7-amd64 60.99% <100.00%> (ø)
arch-7-arm32v6 60.87% <100.00%> (ø)
arch-7-arm32v7 60.87% <100.00%> (-0.01%) ⬇️
arch-7-arm64v8 60.99% <100.00%> (ø)
arch-7-i386 60.87% <100.00%> (?)
arch-7-s390x 60.85% <100.00%> (?)
dbase-extension 57.34% <20.00%> (-0.01%) ⬇️
recode-extension 57.29% <20.00%> (-0.01%) ⬇️
unit-7.1-ubuntu-latest ?
unit-7.2-ubuntu-latest 57.47% <25.00%> (ø)
unit-7.3-ubuntu-latest 61.01% <100.00%> (ø)
unit-7.4-ubuntu-latest 61.01% <100.00%> (ø)
unit-8.0-ubuntu-latest 61.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lasses/Controllers/Server/PrivilegesController.php 0.00% <0.00%> (ø)
libraries/classes/Server/Privileges.php 63.34% <100.00%> (ø)
libraries/classes/Git.php 59.72% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f62ba...3f985e2. Read the comment docs.

…the privileges tab

Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
@iifawzi iifawzi force-pushed the fixing-granting-from-privileges-tab branch from 71b27d0 to 3f985e2 Compare July 28, 2021 15:26
@williamdes williamdes added this to the 5.1.2 milestone Jul 28, 2021
@williamdes williamdes added this to In progress in pull-requests via automation Jul 28, 2021
@williamdes williamdes moved this from In progress to Review in progress in pull-requests Jul 28, 2021
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thank you !

pull-requests automation moved this from Review in progress to Reviewer approved Jul 28, 2021
@williamdes williamdes self-assigned this Jul 29, 2021
@williamdes
Copy link
Member

Confirmed !
Before and after
image

@williamdes williamdes merged commit 4b9a962 into phpmyadmin:QA_5_1 Jul 29, 2021
pull-requests automation moved this from Reviewer approved to Done Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
pull-requests
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants