Fix #17482 - default to "Full texts" when running explain statements

[iifawzi]

Description

Hi, this should fix #17482.
Fixes #17482

[iifawzi]

I'm not very sure that this's the correct way of testing this.

[iifawzi]

I think it's not testing against the SQL-Parser#dev-master. I've hard-coded the SQL-Parser changes on my machine and it passed.

[williamdes]

I think it's not testing against the SQL-Parser#dev-master. I've hard-coded the SQL-Parser changes on my machine and it passed.

yeah, you should update in this PR the hash I put in the composer.json file ;)

[iifawzi]

what do you mean by updating the hash @williamdes?

[williamdes]

what do you mean by updating the hash @williamdes?

phpmyadmin/composer.json

Line 64 in 9a84527

"phpmyadmin/sql-parser": "dev-master#a9cd167be77829ec2dd4496ce1010ed6abde92f8",

[codecov]

Codecov Report

Base: 49.71% // Head: 49.77% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (706c08a) compared to base (1bf31e5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff              @@
##             QA_5_2   #17906      +/-   ##
============================================
+ Coverage     49.71%   49.77%   +0.05%     
- Complexity    16742    16743       +1     
============================================
  Files           602      602              
  Lines         59784    59858      +74     
============================================
+ Hits          29722    29792      +70     
- Misses        30062    30066       +4     

Flag	Coverage Δ
dbase-extension	49.56% <100.00%> (+0.64%)	⬆️
recode-extension	49.53% <100.00%> (+0.04%)	⬆️
unit-7.2-ubuntu-latest	48.41% <100.00%> (+0.06%)	⬆️
unit-7.3-ubuntu-latest	50.24% <100.00%> (+0.67%)	⬆️
unit-7.4-ubuntu-latest	49.76% <100.00%> (+0.21%)	⬆️
unit-8.0-ubuntu-latest	49.86% <100.00%> (+0.17%)	⬆️
unit-8.1-ubuntu-latest	49.85% <100.00%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
libraries/classes/Display/Results.php	60.58% <100.00%> (+0.04%)	⬆️
libraries/classes/Sql.php	47.19% <100.00%> (+0.14%)	⬆️
libraries/classes/Partitioning/Partition.php	17.20% <0.00%> (-8.61%)	⬇️
libraries/classes/BrowseForeigners.php	60.52% <0.00%> (-1.22%)	⬇️
libraries/classes/Transformations.php	60.91% <0.00%> (-0.51%)	⬇️
libraries/classes/Navigation/Nodes/NodeColumn.php	80.00% <0.00%> (-0.49%)	⬇️
libraries/classes/CheckUserPrivileges.php	34.45% <0.00%> (-0.24%)	⬇️
libraries/classes/Config/FormDisplay.php	24.41% <0.00%> (-0.20%)	⬇️
...s/classes/Controllers/Table/RelationController.php	22.75% <0.00%> (-0.16%)	⬇️
libraries/classes/InsertEdit.php	87.64% <0.00%> (-0.08%)	⬇️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[williamdes]

Looks good, will test it
Thank you for your work on this subject :)

[nunoperalta]

Thank you very much for this, guys. You're amazing! 🤩🥳🎉

[williamdes]

The (phpMyAdmin 5.2+snapshot) also available as a non official docker image is updated with this PR 🚀