Fix #17398 - Fixing clicking on JSON columns triggers update query
#17976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 47.22% // Head: 47.73% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## QA_5_2 #17976 +/- ##
============================================
+ Coverage 47.22% 47.73% +0.50%
Complexity 16825 16825
============================================
Files 602 602
Lines 71576 71576
============================================
+ Hits 33805 34164 +359
+ Misses 37771 37412 -359
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
williamdes
approved these changes
Dec 19, 2022
williamdes
reviewed
Jan 8, 2023
…e query it also fixes the issue where the JSON columns are saved with spaces and new lines, after being updated from the UI. Fixes: phpmyadmin#17398 Signed-off-by: iifawzi <iifawzie@gmail.com>
… JS Function Signed-off-by: iifawzi <iifawzie@gmail.com>
iifawzi
force-pushed
the
fixing-json-columns
branch
from
b8c4e7d
to
cb6012c
Compare
Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
williamdes
reviewed
Jan 14, 2023
williamdes
reviewed
Jan 14, 2023
Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
iifawzi
force-pushed
the
fixing-json-columns
branch
from
7fe40f5
to
b860117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi, This PR is fixing the two issues mentioned at #17398
1- An
updatequery is executed when clicking on theJSONcolumns2- The
JSONcolumns values are saved with unneeded spaces and lines when updatedScreen.Recording.2022-12-19.at.2.23.13.AM.mov
Fixes #17398