Microoptimization of fetchResult()

[kamil-tekiela]

The performance difference is 0.8% (viewing DB with 14k tables)... It shows again that function calls in PHP are not really that expensive.

You may think that it wasn't worth my effort, but I actually did this for another reason: it makes the trace file much smaller.

[codecov]

Codecov Report

Base: 52.40% // Head: 52.42% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (fd52b85) compared to base (13890a9).
Patch coverage: 76.92% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #17979      +/-   ##
============================================
+ Coverage     52.40%   52.42%   +0.01%     
- Complexity    16935    16938       +3     
============================================
  Files           619      619              
  Lines         70832    70829       -3     
============================================
+ Hits          37123    37131       +8     
+ Misses        33709    33698      -11     

Flag	Coverage Δ
dbase-extension	53.50% <76.92%> (-0.01%)	⬇️
recode-extension	53.47% <76.92%> (-0.01%)	⬇️
unit-7.2-ubuntu-latest	53.43% <76.92%> (-0.01%)	⬇️
unit-7.3-ubuntu-latest	53.32% <76.92%> (-0.01%)	⬇️
unit-7.4-ubuntu-latest	53.33% <76.92%> (-0.01%)	⬇️
unit-8.0-ubuntu-latest	53.34% <76.92%> (-0.01%)	⬇️
unit-8.1-ubuntu-latest	53.35% <76.92%> (+0.01%)	⬆️
unit-8.2-ubuntu-latest	53.34% <76.92%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
libraries/classes/DatabaseInterface.php	39.16% <76.92%> (-0.40%)	⬇️
libraries/classes/ResponseRenderer.php	13.75% <0.00%> (+7.50%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.