Bugfix for changing $cfg['RepeatCells'] no effect #18009
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: still-dreaming-1 <jessedickey@gmail.com>
|
Actually, I thought I wanted this setting to work, but now that it does, I don't like it. I just realized the header floats at the top as I scroll down the list of results anyways, so I don't need this setting. I guess I would like to be able to disable it if it is not already disabled. I'm not sure if the original code had it disabled or stuck at the default setting of 100. |
|
Thank you for this patch, we need to have a deeper look before merging this |
|
Yeah, I'm not sure it makes sense anymore. Maybe the setting should be removed entirely in favor of the floating header. I think it doesn't float with some of the other PhpMyAdmin themes though. |
|
Let's keep it open until it's debugged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes changing $cfg['RepeatCells'] in configuration has no effect.
I'm not sure if this is a good way to fix this or not, but it does fix this problem for me in my local environment. I'm not sure what the purpose of checking
empty($query['repeat_cells'])was in the original code.Signed-off-by: still-dreaming-1 jessedickey@gmail.com