New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for sql.lib.php and parse_analyze.inc.php. #1816

Merged
merged 7 commits into from Jul 26, 2015

Conversation

Projects
None yet
2 participants
@udan11
Member

udan11 commented Jul 23, 2015

Added tests for sql.lib.php and parse_analyze.inc.php.
Removed dead code.
Fixed miscellaneous issues.
Fixed a bug in PMA_isJustBrowsing().
Updated sql-parser library to udan11/sql-parser@e713c9f.

Signed-off-by: Dan Ungureanu udan1107@gmail.com

@udan11 udan11 force-pushed the udan11:misc branch from c883a3a to 9fb7259 Jul 23, 2015

@lem9 lem9 self-assigned this Jul 24, 2015

@udan11 udan11 force-pushed the udan11:misc branch from 1bcd745 to 46664b8 Jul 25, 2015

@lem9

This comment has been minimized.

Contributor

lem9 commented Jul 25, 2015

Please fix the failing test.

@lem9

This comment has been minimized.

Contributor

lem9 commented Jul 25, 2015

Dan,
there is still a problem in PMA_SqlTest::testIsJustBrowsing.

@udan11 udan11 force-pushed the udan11:misc branch from b726c4d to 4ccf320 Jul 25, 2015

udan11 added some commits Jul 23, 2015

Added tests for sql.lib.php and parse_analyze.inc.php.
Removed dead code.
Fixed miscellaneous issues.
Fixed a bug in PMA_isJustBrowsing().
Updated sql-parser library to udan11/sql-parser@e713c9f.

Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Fixed a few more issues.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Fixed more issues.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Fixed visibility.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Avoid redefinition.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Fixed visibility.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Updated tests.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>

@udan11 udan11 force-pushed the udan11:misc branch from 4ccf320 to 1b4a684 Jul 25, 2015

@udan11

This comment has been minimized.

Member

udan11 commented Jul 25, 2015

Everything should be fine now. Also rebased to fix merge conflict.

@lem9

This comment has been minimized.

The underscore prefixing a method is a convention meaning that this method is private.

This comment has been minimized.

Owner

udan11 replied Jul 25, 2015

Yes, I'm aware, but the PHPDoc said that is a private method and it's name was also denoting that it was a private method. In practice, it looks like it is being called outside the class too. I'll rename these soon, but for now I wanted it to pass all the tests to make sure I didn't break anything.

This comment has been minimized.

Owner

udan11 replied Jul 26, 2015

I looked into it and I can't rename these without affecting the libraries that are being used. All these methods that don't follow the standards are overriding methods existent methods.

This comment has been minimized.

lem9 replied Jul 26, 2015

Thanks for looking into it.

lem9 added a commit that referenced this pull request Jul 26, 2015

Merge pull request #1816 from udan11/misc
Added tests for sql.lib.php and parse_analyze.inc.php.

@lem9 lem9 merged commit a240b32 into phpmyadmin:master Jul 26, 2015

3 checks passed

Scrutinizer 29 new issues, 6 updated code elements
Details
codacy/pr Good work! The project quality is stable.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lem9

This comment has been minimized.

Contributor

lem9 commented Jul 26, 2015

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment