Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for sql.lib.php and parse_analyze.inc.php. #1816

Merged
merged 7 commits into from Jul 26, 2015

Conversation

@udan11
Copy link
Member

@udan11 udan11 commented Jul 23, 2015

Added tests for sql.lib.php and parse_analyze.inc.php.
Removed dead code.
Fixed miscellaneous issues.
Fixed a bug in PMA_isJustBrowsing().
Updated sql-parser library to phpmyadmin/sql-parser@e713c9f.

Signed-off-by: Dan Ungureanu udan1107@gmail.com

@lem9 lem9 self-assigned this Jul 24, 2015
@lem9
Copy link
Contributor

@lem9 lem9 commented Jul 25, 2015

Please fix the failing test.

@lem9
Copy link
Contributor

@lem9 lem9 commented Jul 25, 2015

Dan,
there is still a problem in PMA_SqlTest::testIsJustBrowsing.

Dan Ungureanu added 7 commits Jul 23, 2015
Removed dead code.
Fixed miscellaneous issues.
Fixed a bug in PMA_isJustBrowsing().
Updated sql-parser library to phpmyadmin/sql-parser@e713c9f.

Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
Dan Ungureanu
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
@udan11
Copy link
Member Author

@udan11 udan11 commented Jul 25, 2015

Everything should be fine now. Also rebased to fix merge conflict.

lem9 added a commit that referenced this pull request Jul 26, 2015
Added tests for sql.lib.php and parse_analyze.inc.php.
@lem9 lem9 merged commit a240b32 into phpmyadmin:master Jul 26, 2015
3 checks passed
3 checks passed
Scrutinizer 29 new issues, 6 updated code elements
Details
codacy/pr Good work! The project quality is stable.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lem9
Copy link
Contributor

@lem9 lem9 commented Jul 26, 2015

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants