Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing transformation tests on 32 bit #18270

Conversation

kamil-tekiela
Copy link
Contributor

Let's see if this fixes tests on ARM. They fail because the value for invalid IP is undefined and depends on the platform. I guess it's because of signed integers, but I have no way of testing this on ARM myself.

@kamil-tekiela kamil-tekiela force-pushed the Fix-failing-transformation-tests-on-ARM branch from 335cbf3 to 0fc8d0f Compare March 17, 2023 22:31
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 20.68% and project coverage change: -0.74 ⚠️

Comparison is base (cff126e) 54.93% compared to head (0fc8d0f) 54.19%.

❗ Current head 0fc8d0f differs from pull request most recent head 2b92201. Consider uploading reports for the commit 2b92201 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18270      +/-   ##
============================================
- Coverage     54.93%   54.19%   -0.74%     
- Complexity    16401    16416      +15     
============================================
  Files           628      627       -1     
  Lines         64550    67648    +3098     
============================================
+ Hits          35458    36661    +1203     
- Misses        29092    30987    +1895     
Flag Coverage Δ
dbase-extension 54.17% <20.68%> (?)
recode-extension 54.14% <20.68%> (?)
unit-8.1-ubuntu-latest 54.16% <20.68%> (-0.77%) ⬇️
unit-8.2-ubuntu-latest 54.14% <20.68%> (-0.79%) ⬇️
unit-nightly-ubuntu-latest 54.16% <20.68%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sformations/Abs/Bool2TextTransformationsPlugin.php 0.00% <0.00%> (ø)
...tions/Abs/CodeMirrorEditorTransformationPlugin.php 0.00% <0.00%> (ø)
...formations/Abs/DateFormatTransformationsPlugin.php 0.00% <0.00%> (ø)
...nsformations/Abs/DownloadTransformationsPlugin.php 0.00% <0.00%> (ø)
...nsformations/Abs/ExternalTransformationsPlugin.php 0.00% <0.00%> (ø)
...sformations/Abs/FormattedTransformationsPlugin.php 0.00% <0.00%> (ø)
...s/Transformations/Abs/HexTransformationsPlugin.php 0.00% <0.00%> (ø)
...sformations/Abs/ImageLinkTransformationsPlugin.php 0.00% <0.00%> (ø)
...ormations/Abs/ImageUploadTransformationsPlugin.php 0.00% <0.00%> (ø)
...ransformations/Abs/InlineTransformationsPlugin.php 0.00% <0.00%> (ø)
... and 15 more

... and 223 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@williamdes
Copy link
Member

but I have no way of testing this on ARM myself.

If you have Docker locally you can do like in our tests:

- name: Set up multi arch support
run: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
- name: Print arch
run: docker run --rm ${{ matrix.arch }}/alpine:3.17 uname -a
- name: Run tests on php ${{ matrix.php-version }}
run: docker run -v $PWD:/app --workdir /app --rm ${{ matrix.arch }}/alpine:3.17 sh /app/do-tests.sh

You can launch yourself a container running on another arch

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth force-pushed the Fix-failing-transformation-tests-on-ARM branch from 0fc8d0f to 2b92201 Compare March 29, 2023 19:43
@MauricioFauth MauricioFauth changed the title Fix failing transformation tests on arm Fix failing transformation tests on 32 bit Mar 29, 2023
@MauricioFauth MauricioFauth merged commit e6cd40d into phpmyadmin:master Mar 29, 2023
42 of 43 checks passed
@MauricioFauth MauricioFauth self-assigned this Mar 29, 2023
@kamil-tekiela kamil-tekiela deleted the Fix-failing-transformation-tests-on-ARM branch March 30, 2023 14:51
@williamdes williamdes added this to the 6.0.0 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants