-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing transformation tests on 32 bit #18270
Fix failing transformation tests on 32 bit #18270
Conversation
335cbf3
to
0fc8d0f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #18270 +/- ##
============================================
- Coverage 54.93% 54.19% -0.74%
- Complexity 16401 16416 +15
============================================
Files 628 627 -1
Lines 64550 67648 +3098
============================================
+ Hits 35458 36661 +1203
- Misses 29092 30987 +1895
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 223 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
If you have Docker locally you can do like in our tests: phpmyadmin/.github/workflows/tests.yml Lines 54 to 61 in 3f12593
You can launch yourself a container running on another arch |
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
0fc8d0f
to
2b92201
Compare
Let's see if this fixes tests on ARM. They fail because the value for invalid IP is undefined and depends on the platform. I guess it's because of signed integers, but I have no way of testing this on ARM myself.