Don't parse SQL if no tracking is in progress

[kamil-tekiela]

Surprisingly, performing an SQL query is better for performance than parsing the query unnecessarily. Tested with 250 tables for about 50% better performance.

Ref. #18249

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.83 🎉

Comparison is base (5e0caaf) 47.07% compared to head (8550db2) 47.90%.

Additional details and impacted files

@@             Coverage Diff              @@
##             QA_5_2   #18280      +/-   ##
============================================
+ Coverage     47.07%   47.90%   +0.83%     
- Complexity    16973    16975       +2     
============================================
  Files           607      607              
  Lines         72306    72316      +10     
============================================
+ Hits          34038    34644     +606     
+ Misses        38268    37672     -596     

Flag	Coverage Δ
dbase-extension	47.33% <0.00%> (-0.04%)	⬇️
recode-extension	47.31% <0.00%> (-0.59%)	⬇️
unit-7.2-ubuntu-latest	47.34% <0.00%> (+0.02%)	⬆️
unit-7.3-ubuntu-latest	47.83% <0.00%> (+0.01%)	⬆️
unit-7.4-ubuntu-latest	47.77% <0.00%> (-0.06%)	⬇️
unit-8.0-ubuntu-latest	47.87% <0.00%> (-0.01%)	⬇️
unit-8.1-ubuntu-latest	49.21% <0.00%> (+1.36%)	⬆️
unit-8.2-ubuntu-latest	47.85% <0.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
libraries/classes/Tracker.php	75.00% <0.00%> (-1.93%)	⬇️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[williamdes]

Awesome !

[liviuconcioiu]

@kamil-tekiela Thank you for the great work! BTW, this PR will also fix the issues with import of large tables/databases.

In my case, opening a database with 250 tables (50% performance increase) and importing a table (25 MB in size and 25000 rows), before this PR it took 4 minutes and 30 seconds. Now it takes 30 seconds!