Constructor property promotion - risky

[kamil-tekiela]

This is fixing some more property promotions, but they could potentially be risky. Although, these seem to be fine in PMA.

[codecov]

Codecov Report

Patch coverage: 68.75% and project coverage change: -0.02% ⚠️

Comparison is base (7e9ce8d) 56.03% compared to head (95a98cc) 56.01%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #18625      +/-   ##
============================================
- Coverage     56.03%   56.01%   -0.02%     
+ Complexity    16187    16185       -2     
============================================
  Files           642      642              
  Lines         63856    63819      -37     
============================================
- Hits          35779    35747      -32     
+ Misses        28077    28072       -5     

Flag	Coverage Δ
dbase-extension	56.01% <68.75%> (-0.02%)	⬇️
unit-8.1-ubuntu-latest	55.98% <68.75%> (-0.02%)	⬇️
unit-8.2-ubuntu-latest	55.98% <68.75%> (-0.02%)	⬇️
unit-nightly-ubuntu-latest	55.94% <68.75%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
libraries/classes/Charsets/Charset.php	100.00% <ø> (ø)
libraries/classes/Charsets/Collation.php	99.71% <ø> (-0.01%)	⬇️
libraries/classes/Config/Form.php	92.30% <ø> (-0.17%)	⬇️
.../Controllers/Table/Partition/AnalyzeController.php	50.00% <ø> (-2.18%)	⬇️
...es/Controllers/Table/Partition/CheckController.php	50.00% <ø> (-2.18%)	⬇️
...ses/Controllers/Table/Partition/DropController.php	45.83% <ø> (-2.17%)	⬇️
...Controllers/Table/Partition/OptimizeController.php	50.00% <ø> (-2.18%)	⬇️
.../Controllers/Table/Partition/RebuildController.php	45.83% <ø> (-2.17%)	⬇️
...s/Controllers/Table/Partition/RepairController.php	50.00% <ø> (-2.18%)	⬇️
...Controllers/Table/Partition/TruncateController.php	45.83% <ø> (-2.17%)	⬇️
... and 13 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.