Fix #18962 - Moving columns with ENUM() datatype and DEFAULT value causes invalid SQL

[johnson361]

Description

 SELECT
    `COLUMN_NAME` AS `Field`,
    `COLUMN_TYPE` AS `Type`,
    `COLLATION_NAME` AS `Collation`,
    `IS_NULLABLE` AS `Null`,
    `COLUMN_KEY` AS `Key`,
    `COLUMN_DEFAULT` AS `Default`,
    `EXTRA` AS `Extra`,
    `PRIVILEGES` AS `Privileges`,
    `COLUMN_COMMENT` AS `Comment`
FROM
    `information_schema`.`COLUMNS`  where `TABLE_SCHEMA` = 'test'  AND `TABLE_NAME` = 'test' ;;

When executing this query on MariaDB, the COLUMN_DEFAULT column returns default values enclosed in single quotes on both sides, causing an issue. However, in MySQL, this behavior is not observed. To address the inconsistency, I needed to trim off any extra single quotes that might exist in the COLUMN_DEFAULT values using TRIM('\'' FROM COLUMN_DEFAULT`). Now, the issue is resolved.

Fixes #18962

You can see how the data appeared before the query modifications in the image below.
[

]

[johnson361]

Can anyone please review my PR ?

[ChrisHSandN]

If you trim ' off then this will fail if the default value starts or ends with an ' e.g.

CREATE TABLE `test` (
  `id` int(11) NOT NULL,
  `enum` enum('yes','no','''foo') COLLATE utf8_unicode_ci NOT NULL DEFAULT '''foo',
  PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci

Can it use the same logic as the Structure tab as this looks to work correctly even if there is a leading ':

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 48.61%. Comparing base (4eb4a1a) to head (f07285e).
Report is 13 commits behind head on QA_5_2.

Files	Patch %	Lines
...trollers/Table/Structure/MoveColumnsController.php	0.00%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             QA_5_2   #19009   +/-   ##
=========================================
  Coverage     48.61%   48.61%           
- Complexity    17006    17027   +21     
=========================================
  Files           607      607           
  Lines         72318    72366   +48     
=========================================
+ Hits          35154    35182   +28     
- Misses        37164    37184   +20     

Flag	Coverage Δ
dbase-extension	48.21% <0.00%> (+0.04%)	⬆️
recode-extension	48.14% <0.00%> (-1.14%)	⬇️
unit-7.2-ubuntu-latest	48.59% <0.00%> (+0.51%)	⬆️
unit-7.3-ubuntu-latest	48.54% <0.00%> (-0.76%)	⬇️
unit-7.4-ubuntu-latest	49.87% <0.00%> (+1.37%)	⬆️
unit-8.0-ubuntu-latest	48.57% <0.00%> (+0.02%)	⬆️
unit-8.1-ubuntu-latest	48.58% <0.00%> (-0.73%)	⬇️
unit-8.2-ubuntu-latest	48.50% <0.00%> (-0.06%)	⬇️
unit-8.3-ubuntu-latest	49.83% <0.00%> (+1.27%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[johnson361]

@ChrisHSandN i have updated the logic . Please retest. Thank you .

[williamdes]

Closing this one since #19105 got merged

Thank you for contributing to fix this issue. Please test with the new changes and let us know