Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18437 - SQL editor's alignment in rtl #19088

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rezsk
Copy link

@rezsk rezsk commented Mar 31, 2024

Description

Fixes code mirror alignment issues with RTL mode.

Fixes #18437

Signed-off-by: Reza Askari <git@rzsk.net>
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.18%. Comparing base (d61a059) to head (c51358a).
Report is 3 commits behind head on master.

❗ Current head c51358a differs from pull request most recent head a3046c6. Consider uploading reports for the commit a3046c6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #19088   +/-   ##
=========================================
  Coverage     59.18%   59.18%           
  Complexity    15908    15908           
=========================================
  Files           671      671           
  Lines         61293    61293           
=========================================
  Hits          36277    36277           
  Misses        25016    25016           
Flag Coverage Δ
dbase-extension 59.18% <ø> (ø)
unit-8.1-ubuntu-latest 59.10% <ø> (ø)
unit-8.2-ubuntu-latest 59.11% <ø> (ø)
unit-8.3-ubuntu-latest 59.11% <ø> (+0.04%) ⬆️
unit-8.4-ubuntu-latest 59.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Reza Askari <git@rzsk.net>
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this should go to our QA branch when merged

@williamdes williamdes changed the title Fix SQL editor's alignment in rtl Fix #18437 - SQL editor's alignment in rtl Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query not visible for RTL languages
3 participants