Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18495 - exporting of triggers #19090

Merged
merged 2 commits into from Apr 15, 2024

Conversation

MoonE
Copy link
Contributor

@MoonE MoonE commented Apr 1, 2024

Description

Add missing $$ delimiter after exported triggers.

Fixes #18495

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.61%. Comparing base (1d83673) to head (ec2d9ba).
Report is 10 commits behind head on QA_5_2.

Additional details and impacted files
@@             Coverage Diff              @@
##             QA_5_2   #19090      +/-   ##
============================================
+ Coverage     47.38%   48.61%   +1.22%     
- Complexity    17026    17028       +2     
============================================
  Files           607      607              
  Lines         72363    72365       +2     
============================================
+ Hits          34292    35182     +890     
+ Misses        38071    37183     -888     
Flag Coverage Δ
dbase-extension 48.14% <100.00%> (+<0.01%) ⬆️
recode-extension 48.67% <100.00%> (+0.51%) ⬆️
unit-7.2-ubuntu-latest 48.09% <100.00%> (-0.08%) ⬇️
unit-7.3-ubuntu-latest 48.54% <100.00%> (+0.01%) ⬆️
unit-7.4-ubuntu-latest 48.49% <100.00%> (-0.08%) ⬇️
unit-8.0-ubuntu-latest 48.63% <100.00%> (+0.07%) ⬆️
unit-8.1-ubuntu-latest 49.83% <100.00%> (+1.24%) ⬆️
unit-8.2-ubuntu-latest 48.55% <100.00%> (+<0.01%) ⬆️
unit-8.3-ubuntu-latest 49.86% <100.00%> (+1.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MoonE !!

@williamdes williamdes self-assigned this Apr 15, 2024
@williamdes williamdes added this to the 5.2.2 milestone Apr 15, 2024
@williamdes williamdes changed the title Fix exporting of triggers Fixes #18495 - exporting of triggers Apr 15, 2024
@williamdes williamdes changed the title Fixes #18495 - exporting of triggers Fix #18495 - exporting of triggers Apr 15, 2024
@williamdes williamdes merged commit ec78dfd into phpmyadmin:QA_5_2 Apr 15, 2024
30 of 32 checks passed
@MoonE MoonE deleted the fix-export-triggers branch April 15, 2024 19:32
@williamdes
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants