Configurable menus #484
Merged
Configurable menus #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Kasun, |
|
Thanks Marc, I will update SQLs for new tables accordingly. |
Conflicts: libraries/Menu.class.php libraries/Util.class.php
| array('text', 'both') | ||
| ) | ||
| ) { | ||
| if (in_array($GLOBALS['cfg']['TabsMode'], array('text', 'both'))) { |
There was a problem hiding this comment.
@lem9, you last modified these lines, so double-checking with you that there's no problem to make one line out of five. It's still under our line-length limit, so I have no problem unless you kept it on multiple lines for a specific reason. There are a number of cases like this which are all similar
There was a problem hiding this comment.
@ibennetch you can make one line out of five
|
Nice work, Kasun! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.