Add test case to check partition name starting by a number

Signed-off-by: Hugues Peccatte <hugues.peccatte@aareon.fr>
phpmyadmin · Nov 1, 2019 · ccb20a1 · ccb20a1
1 parent fe98a34
commit ccb20a1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Components/PartitionDefinition.php b/src/Components/PartitionDefinition.php
@@ -172,7 +172,7 @@ public static function parse(Parser $parser, TokensList $list, array $options =
                 // Looking ahead for a 'VALUES' keyword.
                 // Loop until the end of the partition name (delimited by a whitespace)
                 while ($nextToken = $list->tokens[++$list->idx]) {
-                    if ($nextToken->type === Token::TYPE_WHITESPACE) {
+                    if ($nextToken->type !== Token::TYPE_NONE) {
                         break;
                     }
                     $ret->name .= $nextToken->value;

diff --git a/tests/Components/PartitionDefinitionTest.php b/tests/Components/PartitionDefinitionTest.php
@@ -19,4 +19,16 @@ public function testParse()
         $this->assertEquals('LESS THAN', $component->type);
         $this->assertEquals('(1990)', $component->expr->expr);
     }
+
+    public function testParseNameWithUnderscore()
+    {
+        $component = PartitionDefinition::parse(
+            new Parser(),
+            $this->getTokensList('PARTITION 2017_12 VALUES LESS THAN (\'2018-01-01 00:00:00\') ENGINE = MyISAM')
+        );
+        $this->assertFalse($component->isSubpartition);
+        $this->assertEquals('2017_12', $component->name);
+        $this->assertEquals('LESS THAN', $component->type);
+        $this->assertEquals('(\'2018-01-01 00:00:00\')', $component->expr->expr);
+    }
 }