Swap empty for array check

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
phpmyadmin · Jul 22, 2023 · ecc447c · ecc447c
1 parent 1cc7394
commit ecc447c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -1421,7 +1421,7 @@
       <code>has</code>
     </PossiblyNullReference>
     <RedundantCondition>
-      <code><![CDATA[empty($ret['select_tables'])]]></code>
+      <code><![CDATA[$ret['select_tables'] === []]]></code>
     </RedundantCondition>
   </file>
   <file src="src/Utils/Routine.php">

diff --git a/src/Utils/Query.php b/src/Utils/Query.php
@@ -528,7 +528,7 @@ public static function getAll($query)
             // If no tables names were found in the SELECT clause or if there
             // are expressions like * or COUNT(*), etc. tables names should be
             // extracted from the FROM clause.
-            if (empty($ret['select_tables'])) {
+            if ($ret['select_tables'] === []) {
                 foreach ($statement->from as $expr) {
                     if (! isset($expr->table) || ($expr->table === '')) {
                         continue;