Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTER EVENT … RENAME TO new_db.new_event; fails to be understood correctly by the parser #419

Closed
niconoe- opened this issue Feb 1, 2023 · 3 comments · Fixed by #420
Closed
Assignees
Labels
Milestone

Comments

@niconoe-
Copy link
Contributor

niconoe- commented Feb 1, 2023

If you try to parse the following query:

ALTER EVENT my_old_event RENAME TO new_db.new_event;

the expression "new_db.new_event" fails to be understood correctly by the parser because the option TO on the event option is wrongly defined as "var" rather than "expr".

See: https://github.com/phpmyadmin/sql-parser/pull/420/files/090d759c1df5d31c65579234620718a13a013352#r1093700402

Related PR: #420

@niconoe-
Copy link
Contributor Author

niconoe- commented Feb 3, 2023

@williamdes As #420 is now merged, I don't know if you want to close this right now of if you want to prefer a new version to be released with this fix before.

@williamdes williamdes self-assigned this Feb 3, 2023
@williamdes williamdes added the bug label Feb 3, 2023
@williamdes williamdes added this to the 5.8.0 milestone Feb 3, 2023
@williamdes
Copy link
Member

Ah, the PR missed a Fixes: #419 line :/

@williamdes
Copy link
Member

@williamdes As #420 is now merged, I don't know if you want to close this right now of if you want to prefer a new version to be released with this fix before.

Normally PRs close issues and we milestone both of them
And one day there is a release of the changes ^^

williamdes added a commit that referenced this issue Feb 26, 2023
Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants