-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes importing inline comments #13139 #147
Conversation
Signed-off-by: Raghuram Vadapalli<raghuram.vadapalli@research.iiit.ac.in>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the test failure, it seems that it breaks parsing comments terminated by \n.
I am not much familiar with parser project. Is it possible to run these tests on local machine. |
See #147 Signed-off-by: Michal Čihař <michal@cihar.com>
Indeed the documentation on this was missing, I've just added it: https://github.com/phpmyadmin/sql-parser/blob/master/CONTRIBUTING.md |
It's mostly useful for debugging changes in parser. See #147. Signed-off-by: Michal Čihař <michal@cihar.com>
I've also added script bin/tokenize-query which you can use for testing parser as well. With your changes the following query is tokenized wrongly:
See:
While the correct (and current) tokenization is:
|
I've come with different fix, which does not break tokenization, see #148. |
Closing this for now as it's breaking tokenization. Either we will use #148 or different patch is needed. |
It's mostly useful for debugging changes in parser. See phpmyadmin#147. Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Raghuram Vadapalli raghuram.vadapalli@research.iiit.ac.in