-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #339 - Fixing the issue of not handling the procedures's options #346
Conversation
Codecov Report
@@ Coverage Diff @@
## QA #346 +/- ##
=========================================
Coverage 99.80% 99.80%
Complexity 1916 1916
=========================================
Files 63 63
Lines 4604 4605 +1
=========================================
+ Hits 4595 4596 +1
Misses 9 9
Continue to review full report at Codecov.
|
I've made a fake integration with PMA, and all the tests passed too :') |
17377a8
to
91aad6f
Compare
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
91aad6f
to
58f852a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect
@@ -52,6 +52,7 @@ public function alterProvider() | |||
array('parser/parseAlterUser5'), | |||
array('parser/parseAlterUser6'), | |||
array('parser/parseAlterUser7'), | |||
array('parser/parseAlterUser8'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I forgot to let you know I had patched it in: 1acb64c
Hi, This PR should fix the issues relating to #339
The issue was in
sql-parser/src/Statements/CreateStatement.php
Lines 221 to 237 in 2d1efde
it had some wrong tokens, and wasn't have many, which was leading to break the for loop that parses the options tokens
sql-parser/src/Components/OptionsArray.php
Lines 126 to 129 in 2d1efde
I've fixed and added the correct options tokens as much as I could. Ref
Signed-off-by: Fawzi E. Abdulfattah iifawzie@gmail.com