Fixing #348 - Fixing missing KEY options for MySQL and MariaDB #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Desportes <williamdes@wdes.fr>
Codecov Report
@@ Coverage Diff @@
## QA #354 +/- ##
============================================
- Coverage 99.80% 99.78% -0.03%
- Complexity 1921 1931 +10
============================================
Files 63 63
Lines 4622 4647 +25
============================================
+ Hits 4613 4637 +24
- Misses 9 10 +1
Continue to review full report at Codecov.
|
williamdes
approved these changes
Sep 16, 2021
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
williamdes
force-pushed
the
fixing-missing-key-options
branch
from
88a62f0
to
f67869e
Compare
williamdes
reviewed
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR continued the work at #349 and should fix #348 and phpmyadmin/phpmyadmin#17097.
I've also added a test for the invisible key issue.