Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #341 - Fixing validation exception when using enforced option #355

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

iifawzi
Copy link
Contributor

@iifawzi iifawzi commented Sep 16, 2021

Hi, this PR should fix #341

Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #355 (3c2ea7f) into QA (b8fc4f9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                 QA     #355   +/-   ##
=========================================
  Coverage     99.78%   99.78%           
  Complexity     1931     1931           
=========================================
  Files            63       63           
  Lines          4647     4647           
=========================================
  Hits           4637     4637           
  Misses           10       10           
Impacted Files Coverage Δ
src/Components/CreateDefinition.php 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8fc4f9...3c2ea7f. Read the comment docs.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much ! 💯 😍

@williamdes williamdes added this to the 4.7.3 milestone Sep 16, 2021
@williamdes williamdes self-assigned this Sep 16, 2021
@williamdes williamdes force-pushed the fixing-enforced-check-option branch 2 times, most recently from f67869e to 60d101d Compare September 16, 2021 06:09
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@williamdes williamdes merged commit 0b43c26 into phpmyadmin:QA Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants