Adding over keyword to the contexts and modify the Expression allowed keywords

[iifawzi]

Signed-off-by: Fawzi E. Abdulfattah iifawzie@gmail.com
Hi, This PR should fix phpmyadmin/phpmyadmin#17126.

Context references:
https://dev.mysql.com/doc/refman/8.0/en/keywords.html
https://mariadb.com/kb/en/reserved-words/

I've created the PR against the master branch, because some contexts are not exist on the QA branch.

[codecov]

Codecov Report

Merging #360 (53f44fa) into master (949fb85) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #360   +/-   ##
=========================================
  Coverage     95.49%   95.49%           
  Complexity     2023     2023           
=========================================
  Files            67       67           
  Lines          4332     4332           
=========================================
  Hits           4137     4137           
  Misses          195      195           

Impacted Files	Coverage Δ
src/Components/Expression.php	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 949fb85...53f44fa. Read the comment docs.

[iifawzi]

Regarding a test for this, I couldn't find a way to use a specific context while generating the parser's test output. This's needed because the keyword is not present in the default context being used (5.7.0), which will lead to parse it incorrectly, Is there a way @williamdes? I've tried changing the default context, and it worked, but the CI tests would fail then.

Anyway, I've made a fake integration with PhpMyAdmin and it also worked.

[williamdes]

💯

[iifawzi]

The PR would fix this issue too.
#197

[williamdes]

💯
Ready for a merge, tests can be added in another PR then

[williamdes]

I did some kind of adjustment to be able to load contexts depending on the file name, it looks like ANSI cases would be using a similar system

See: 79f555a
Feel free to improve this ;)

[iifawzi]

I did some kind of adjustment to be able to load contexts depending on the file name, it looks like ANSI cases would be using a similar system

See: 79f555a Feel free to improve this ;)

Looks so neat, I’m just thinking of also supporting specifying mysql context

Maybe:

$mysqlDbPos = strpos($input, '_mysqldb_');
elseif ($mysqlDbPos !== false) {
$mysqlDbVersion = (int) substr($name, $mysqlDbPos + 9, 6);
Context::load('MySqlDb' . $mysqlDbPos);
 }

[williamdes]

I did some kind of adjustment to be able to load contexts depending on the file name, it looks like ANSI cases would be using a similar system
See: 79f555a Feel free to improve this ;)

Looks so neat, I’m just thinking of also supporting specifying mysql context

Maybe:

$mysqlDbPos = strpos($input, '_mysqldb_');
elseif ($mysqlDbPos !== false) {
$mysqlDbVersion = (int) substr($name, $mysqlDbPos + 9, 6);
Context::load('MySqlDb' . $mysqlDbPos);
 }

Sure, as soon as one test case uses it, yo avoid dead code