Add @final annotation to Components classes
#362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
=========================================
Coverage 95.41% 95.41%
Complexity 2024 2024
=========================================
Files 67 67
Lines 4336 4336
=========================================
Hits 4137 4137
Misses 199 199
Continue to review full report at Codecov.
|
williamdes
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no reason to extend the
PhpMyAdmin\SqlParser\Componentsclasses, this pull request adds the@finalannotation to these classes. This removes the unsafe instantiation errors reported by PHPStan and Psalm.The
@finalannotation should be replaced with thefinalkeyword in the next major version.Fixes #271.