Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting table structure with COMPRESSED columns #380

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

iifawzi
Copy link
Contributor

@iifawzi iifawzi commented Jul 22, 2022

Hi, this PR should fix #351
I've written a test, and also integrated it with PMA, and worked as expected.

image

@iifawzi iifawzi changed the base branch from master to QA July 22, 2022 00:07
@iifawzi iifawzi changed the base branch from QA to master July 22, 2022 00:07
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #380 (54d3b05) into QA (7778926) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                 QA     #380   +/-   ##
=========================================
  Coverage     99.78%   99.78%           
  Complexity     1931     1931           
=========================================
  Files            63       63           
  Lines          4647     4647           
=========================================
  Hits           4637     4637           
  Misses           10       10           
Impacted Files Coverage Δ
src/Components/CreateDefinition.php 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7778926...54d3b05. Read the comment docs.

Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 💯

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 💯

@williamdes williamdes modified the milestones: 4.7.4, 5.6.0 Jul 22, 2022
@williamdes williamdes changed the base branch from QA to master July 22, 2022 09:44
@williamdes
Copy link
Member

I changed the target for master branch as I do not intend to extend the support of the QA branch except for bugs breaking the code ;)

@williamdes williamdes self-assigned this Jul 22, 2022
@williamdes williamdes merged commit 3837827 into phpmyadmin:master Jul 22, 2022
williamdes added a commit that referenced this pull request Jul 22, 2022
Pull-request: #380

Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting table structure with COMPRESSED column - corrupt SQL
2 participants