Fix #374 - Adding NOT to the select options #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
Codecov ReportBase: 95.64% // Head: 95.64% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
=========================================
Coverage 95.64% 95.64%
Complexity 2144 2144
=========================================
Files 67 67
Lines 4548 4548
=========================================
Hits 4350 4350
Misses 198 198
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Can we add the full query of #374 or is there some more things to fix ? |
Yes, we can add it for sure, there are no more things to fix, the issue was only because of the NOT keyword |
Signed-off-by: iifawzi <iifawzie@gmail.com>
williamdes
added a commit
that referenced
this pull request
Nov 23, 2022
Pull-request: #388 Signed-off-by: William Desportes <williamdes@wdes.fr>
This was referenced Nov 25, 2022
williamdes
added a commit
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, This PR is fixing #374
Fixes #374