Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #326 - Updated contexts to contain multipoint and multipolygon data types. #393

Merged
merged 4 commits into from
Dec 12, 2022

Conversation

iifawzi
Copy link
Contributor

@iifawzi iifawzi commented Nov 26, 2022

Signed-off-by: iifawzi iifawzie@gmail.com

Hi, this PR is fixing #326

Fixes #326

Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Base: 95.60% // Head: 95.60% // No change to project coverage 👍

Coverage data is based on head (ab22290) compared to base (a70dec0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #393   +/-   ##
=========================================
  Coverage     95.60%   95.60%           
  Complexity     2174     2174           
=========================================
  Files            68       68           
  Lines          4617     4617           
=========================================
  Hits           4414     4414           
  Misses          203      203           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
@iifawzi iifawzi force-pushed the update-contexts-support-types branch from 1df1bc0 to ab22290 Compare November 27, 2022 00:32
@williamdes williamdes self-assigned this Dec 10, 2022
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on MySQL 5.5 and MultiPolygon exists. As it is the older version we should support I will stop digging 😄

@williamdes williamdes added this to the 5.6.0 milestone Dec 12, 2022
@williamdes williamdes merged commit e29ed1e into phpmyadmin:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unrecognized multipoint and multipolygon field types
2 participants