Improving the Expression component's allowed keywords
#399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 95.58% // Head: 95.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #399 +/- ##
=========================================
Coverage 95.58% 95.59%
- Complexity 2174 2180 +6
=========================================
Files 68 68
Lines 4691 4701 +10
=========================================
+ Hits 4484 4494 +10
Misses 207 207
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
iifawzi
force-pushed
the
improving-expressions-isnull
branch
from
6caacc6
to
255c77e
Compare
iifawzi
force-pushed
the
improving-expressions-isnull
branch
from
255c77e
to
e6d0cfc
Compare
williamdes
reviewed
Dec 13, 2022
williamdes
reviewed
Dec 13, 2022
williamdes
approved these changes
Dec 13, 2022
iifawzi
force-pushed
the
improving-expressions-isnull
branch
from
12e1687
to
81a39bc
Compare
Fixes: phpmyadmin/phpmyadmin#17422 Signed-off-by: iifawzi <iifawzie@gmail.com>
iifawzi
force-pushed
the
improving-expressions-isnull
branch
from
81a39bc
to
7dc4b80
Compare
|
We need to update all the out files to contain the newly added options, should this be added on a separate PR? |
williamdes
approved these changes
Dec 13, 2022
I would say yes, but do not worry I will do it |
Example: SELECT `test3`.`t1` is not null AS `is_not_null` FROM `test3` Signed-off-by: iifawzi <iifawzie@gmail.com>
iifawzi
commented
Dec 13, 2022
Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
iifawzi
force-pushed
the
improving-expressions-isnull
branch
from
617abf3
to
26cf20e
Compare
iifawzi
changed the title
Expression to allow is null and is not null column optionsExpression component's allowed keywords
Signed-off-by: iifawzi <iifawzie@gmail.com>
williamdes
reviewed
Dec 13, 2022
Signed-off-by: iifawzi <iifawzie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, This PR is improving the
Expressioncomponent allowed keywordsFixes: phpmyadmin/phpmyadmin#17422
Fixes: #396
Fixes: #171
Signed-off-by: iifawzi iifawzie@gmail.com