Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix using ? as a parameter #515

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fix using ? as a parameter #515

merged 1 commit into from
Sep 26, 2023

Conversation

MauricioFauth
Copy link
Member

@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ec459f7) 97.03% compared to head (170dbe5) 97.03%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              5.9.x     #515   +/-   ##
=========================================
  Coverage     97.03%   97.03%           
- Complexity     2240     2243    +3     
=========================================
  Files            69       69           
  Lines          5153     5154    +1     
=========================================
+ Hits           5000     5001    +1     
  Misses          153      153
Files Coverage Δ
src/Components/Condition.php 100.00% <100.00%> (ø)
src/Components/Expression.php 100.00% <100.00%> (ø)
src/Lexer.php 99.74% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MauricioFauth
Fix using ? as a parameter
170dbe5 
- Fixes phpmyadmin#202
- Fixes phpmyadmin#412
- Fixes phpmyadmin#492
- Closes phpmyadmin#499
- Related to phpmyadmin#172

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
williamdes
williamdes approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !
Will it be easy to detect the ? or := for our (broken) feature "Bind parameters" in the query box ?

@MauricioFauth
Copy link
Member Author

Will it be easy to detect the ? or := for our (broken) feature "Bind parameters" in the query box ?

Is there an issue for that?

@MauricioFauth MauricioFauth merged commit 24d734a into phpmyadmin:5.9.x Sep 26, 2023
19 checks passed
@MauricioFauth MauricioFauth deleted the question-mark-param branch September 26, 2023 23:56
@MauricioFauth MauricioFauth self-assigned this Sep 26, 2023
@MauricioFauth MauricioFauth added this to the 5.9.0 milestone Sep 26, 2023
@williamdes
Copy link
Member

Will it be easy to detect the ? or := for our (broken) feature "Bind parameters" in the query box ?

Is there an issue for that?

No, I did not report it until now since the parser has unhappy

@BackEndTea BackEndTea mentioned this pull request Sep 27, 2023
Closed
MauricioFauth added a commit that referenced this pull request Jan 20, 2024
@MauricioFauth
Add change log entries for #515, #498 and #496
011fa18 
[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

Assignees

@MauricioFauth MauricioFauth

Labels
None yet
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MauricioFauth @williamdes