Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Do Not Install #3226

Closed
wants to merge 1 commit into from
Closed

WIP Do Not Install #3226

wants to merge 1 commit into from

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Dec 4, 2022

Test to see if Scrutinizer is run as part of CI.

This is:

- [ ] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Test to see if Scrutinizer is run as part of CI.
@oleibman oleibman marked this pull request as draft December 4, 2022 00:50
@oleibman
Copy link
Collaborator Author

oleibman commented Dec 4, 2022

@PowerKiKi Something has changed between yesterday and today. Scrutinizer was part of the CI test suite yesterday. It isn't today - I noticed that with some earlier PR activity, and created this one as a demonstration. I synced my fork with master, and this branch consists of a single change to a comment. Everything else seems fine, especially including the elimination of Php7.3, but Scrutinizer is nowhere in sight.

@oleibman
Copy link
Collaborator Author

oleibman commented Dec 5, 2022

Hmmm, I just submitted PR #3230, and Scrutinizer is part of the test suite for that. Looks like the problem might have been relative long-lasting but temporary.

@PowerKiKi
Copy link
Member

I don't have any clue why Scrutinizer would disappear and reappear but as long as it is back, it should be fine 😝

So I'll close this for now...

@PowerKiKi PowerKiKi closed this Dec 5, 2022
@oleibman oleibman deleted the scruttest1 branch January 6, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants