Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deptrac #337

Merged
merged 4 commits into from
Apr 12, 2017
Merged

Feature/deptrac #337

merged 4 commits into from
Apr 12, 2017

Conversation

lykciv
Copy link
Contributor

@lykciv lykciv commented Mar 31, 2017

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets #278

New Task Checklist:

  • Is the README.md file updated?
  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpspec tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

The deptrac tool should be installed manually as recommended by their documentation.

Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've added some small remarks.

'formatter_graphviz_dump_html' => null,
]);

$resolver->addAllowedTypes('formatter_graphviz', ['int']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a boolean as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this option so it allows boolean configuration. In deptrac itself this option is an integer though.

{
$resolver = new OptionsResolver();
$resolver->setDefaults([
'formatter_graphviz' => 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I specify a depfile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the depfile option

@@ -0,0 +1,51 @@
# Deptrac

Follow the [installation instructions](https://github.com/sensiolabs-de/deptrac#installation) to add deptrac to your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't deptrac also be installed through composer?
Since it has a composer.json file in it's repository, I guess it should be possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project itself recommends installing the phar file.

Also, the package does not come with a bin file. I guess this should also work when you run php deptrac.php in the package, but I didn't look further into that option.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Let keep it this way for now.

@veewee veewee added this to the Version 0.11.4 milestone Mar 31, 2017
@veewee veewee merged commit 55ffb2b into phpro:master Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants