-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/deptrac #337
Feature/deptrac #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I've added some small remarks.
src/Task/Deptrac.php
Outdated
'formatter_graphviz_dump_html' => null, | ||
]); | ||
|
||
$resolver->addAllowedTypes('formatter_graphviz', ['int']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be a boolean as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this option so it allows boolean configuration. In deptrac itself this option is an integer though.
src/Task/Deptrac.php
Outdated
{ | ||
$resolver = new OptionsResolver(); | ||
$resolver->setDefaults([ | ||
'formatter_graphviz' => 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I specify a depfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the depfile option
@@ -0,0 +1,51 @@ | |||
# Deptrac | |||
|
|||
Follow the [installation instructions](https://github.com/sensiolabs-de/deptrac#installation) to add deptrac to your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't deptrac also be installed through composer?
Since it has a composer.json file in it's repository, I guess it should be possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project itself recommends installing the phar file.
Also, the package does not come with a bin file. I guess this should also work when you run php deptrac.php
in the package, but I didn't look further into that option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Let keep it this way for now.
New Task Checklist:
run()
method readable?run()
method using the configuration correctly?The deptrac tool should be installed manually as recommended by their documentation.