Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the git_conflict task #353

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Conversation

veewee
Copy link
Contributor

@veewee veewee commented Apr 28, 2017

Q A
Branch master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
Documented? yes
Fixed tickets #340

The git_conflict task never worked properly. After doing some investigation, it looks like git is doing this check out of the box. You won't be able to commit when there are unresolved conflicts. Therefor the task has no use and will be deletet.

Don't worry: GrumPHP won't break with your old config!

@veewee veewee added the bug label Apr 28, 2017
@veewee veewee added this to the Version 0.11.5 milestone Apr 28, 2017
@veewee veewee merged commit 6cee7f7 into phpro:master Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant